Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751215AbWHTUgM (ORCPT ); Sun, 20 Aug 2006 16:36:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751228AbWHTUgM (ORCPT ); Sun, 20 Aug 2006 16:36:12 -0400 Received: from mail.gmx.de ([213.165.64.20]:2952 "HELO mail.gmx.net") by vger.kernel.org with SMTP id S1751215AbWHTUgL (ORCPT ); Sun, 20 Aug 2006 16:36:11 -0400 X-Authenticated: #5039886 Date: Sun, 20 Aug 2006 22:36:04 +0200 From: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink To: Arjan van de Ven Cc: Chase Venters , Andrew Morton , Arnd Bergmann , Russell King , rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] introduce kernel_execve function to replace __KERNEL_SYSCALLS__ Message-ID: <20060820203604.GD11843@atjola.homenet> Mail-Followup-To: =?iso-8859-1?Q?Bj=F6rn?= Steinbrink , Arjan van de Ven , Chase Venters , Andrew Morton , Arnd Bergmann , Russell King , rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20060819073031.GA25711@atjola.homenet> <200608201237.13194.chase.venters@clientec.com> <20060820112523.f14fc6dc.akpm@osdl.org> <200608201333.02951.chase.venters@clientec.com> <20060820194552.GB11843@atjola.homenet> <1156103446.23756.60.camel@laptopd505.fenrus.org> <20060820201118.GC11843@atjola.homenet> <1156105229.23756.65.camel@laptopd505.fenrus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1156105229.23756.65.camel@laptopd505.fenrus.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 33 On 2006.08.20 22:20:28 +0200, Arjan van de Ven wrote: > On Sun, 2006-08-20 at 22:11 +0200, Bj?rn Steinbrink wrote: > > On 2006.08.20 21:50:46 +0200, Arjan van de Ven wrote: > > > \ > > > > Could we rename __syscall_return to IS_SYS_ERR (or whatever) and force > > > > kernel syscall users to do the check? That way we could eliminate errno > > > > > > s/users/user/ .. there's one left that should die out soon ;) > > > > > > > Only one in unistd.h, but throughout the kernel there are quite a few > > unless I'm missing something here: > > doener@atjola:~/src/kernel/linux-2.6$ grep \ _syscall * -R | \ > > > grep -v define\\\|undef\\\|clobber | wc -l > > 116 > > > > Are these just going to be replaced by calls to sys_whatever? > > they're not the users of this, they're the definitions... ;) Well, I assume that if some code defines a syscall, it will actually use it. Of course I meant to ask if the users of those definitions are going to just call sys_whatever. For example check_host_supports_tls in arch/um/os-Linux/sys-i386/tls.c which even uses the global errno (although in that case the whole else part could probably be just removed). Bj?rn - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/