Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Rob Herring <robh@kernel.org>, Alice Guo <alice.guo@nxp.com>
CC:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "krzk@kernel.org" <krzk@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
 soc unique ID
Thread-Topic: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
 soc unique ID
Thread-Index: AQHWs0T5AYeWl/nLbkatOQvGj0W++KnAMZOAgACrTQA=
Date:   Tue, 10 Nov 2020 05:25:35 +0000
Message-ID: <DB6PR0402MB27604BD713C4A9EF197AB61788E90@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20201105072629.24175-1-alice.guo@nxp.com>
 <20201109191059.GA1599099@bogus>
In-Reply-To: <20201109191059.GA1599099@bogus>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ae3599ca-f4cf-45af-0289-08d885390d9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 05:25:35.9428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p4PgGWmXvN3kYgwQdCF1vwCJU9b7VdtLGIYi2oQRnOb3MfO3fiblpBO/GhWv7OV7sIiz3goaXB6f0HeChVaLOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3914
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc f=
or
> soc unique ID
>=20
> On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > Add DT Binding doc for the Unique ID of i.MX 8M series.
> >
> > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > ---
> >  .../devicetree/bindings/arm/fsl.yaml          | 33
> +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index e4db0f9ed664..0419f078502b 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -901,6 +901,39 @@ properties:
> >                - fsl,s32v234-evb           # S32V234-EVB2
> Customer Evaluation Board
> >            - const: fsl,s32v234
> >
> > +  soc:
> > +    description:
> > +      i.MX8M Family SoC must provide a soc node in the root of the
> device tree,
> > +      representing the System-on-Chip since these test chips are rathe=
r
> complex.
> > +    type: object
> > +    properties:
> > +      compatible:
> > +        oneOf:
> > +          - items:
> > +              - const: fsl,imx8mm-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mn-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mp-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mq-soc
> > +              - const: simple-bus
>=20
> items:
>   - enum:
>       - fsl,imx8mm-soc
>       - fsl,imx8mn-soc
>       - fsl,imx8mp-soc
>       - fsl,imx8mq-soc
>   - const: simple-bus
>=20
> > +
> > +      nvmem-cells:
> > +        maxItems: 1
> > +        description: Phandle to the SOC Unique ID provided by a nvmem
> node
> > +
> > +      nvmem-cells-names:
> > +        const: soc_unique_id
> > +
> > +    required:
> > +      - compatible
> > +      - nvmem-cells
> > +      - nvmem-cell-names
> > +
>=20
> 'soc' should be required?

The fsl,imx8m[m,n,p,q] already used by root node compatible.
So here could reuse the same compatible string? Or
We add an extra 'soc' here?

Thanks,
Peng.=20

>=20
> >  additionalProperties: true
> >
> >  ...
> > --
> > 2.17.1
> >