Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        Michal Simek <michals@xilinx.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        git <git@xilinx.com>, Shravya Kumbham <shravyak@xilinx.com>
Subject: RE: [PATCH net-next] net: emaclite: Add error handling for
 of_address_ and phy read functions
Thread-Topic: [PATCH net-next] net: emaclite: Add error handling for
 of_address_ and phy read functions
Thread-Index: AQHWseWiNQTJPcLYH02w+4w3GJSlfam9Fn6AgAPOzOA=
Date:   Tue, 10 Nov 2020 06:02:37 +0000
Message-ID: <BYAPR02MB56382AEBE633406AC6A258F1C7E90@BYAPR02MB5638.namprd02.prod.outlook.com>
References: <1604410265-30246-1-git-send-email-radhey.shyam.pandey@xilinx.com>
 <20201107113527.18232c34@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201107113527.18232c34@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 74cc5b0d-e054-423b-97d5-08d8853e39d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 06:02:37.6908
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qnt/SpY8Ge6Fp/LJHgYwd/3WSdv1V2hycYzFjhj/g8/+00XYbJRX2ehN/ydzevAHXkPmqGhWwcCepYhNXkZfFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7133
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Sunday, November 8, 2020 1:05 AM
> To: Radhey Shyam Pandey <radheys@xilinx.com>
> Cc: davem@davemloft.net; Michal Simek <michals@xilinx.com>;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; git <git@xilinx.com>; Shravya Kumbham
> <shravyak@xilinx.com>
> Subject: Re: [PATCH net-next] net: emaclite: Add error handling for
> of_address_ and phy read functions
>=20
> On Tue, 3 Nov 2020 19:01:05 +0530 Radhey Shyam Pandey wrote:
> > From: Shravya Kumbham <shravya.kumbham@xilinx.com>
> >
> > Add ret variable, conditions to check the return value and it's error
> > path for of_address_to_resource() and phy_read() functions.
> >
> > Addresses-Coverity: Event check_return value.
> > Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>=20
> Any reason not to apply this to net as a fix?
Yes, it can be applied to net as a fix.=20
>=20
> > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > index 0c26f5b..fc5ccd1 100644
> > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> > @@ -820,7 +820,7 @@ static int xemaclite_mdio_write(struct mii_bus
> > *bus, int phy_id, int reg,  static int xemaclite_mdio_setup(struct
> > net_local *lp, struct device *dev)  {
> >  	struct mii_bus *bus;
> > -	int rc;
> > +	int rc, ret;
> >  	struct resource res;
> >  	struct device_node *np =3D of_get_parent(lp->phy_node);
> >  	struct device_node *npp;
> > @@ -834,7 +834,13 @@ static int xemaclite_mdio_setup(struct net_local
> *lp, struct device *dev)
> >  	}
> >  	npp =3D of_get_parent(np);
> >
> > -	of_address_to_resource(npp, 0, &res);
> > +	ret =3D of_address_to_resource(npp, 0, &res);
> > +	if (ret) {
> > +		dev_err(dev, "%s resource error!\n",
> > +			dev->of_node->full_name);
> > +		of_node_put(lp->phy_node);
>=20
> I'm always confused by the of_* refcounting. Why do you need to put
> phy_node here, and nowhere else in this function?

Initially, we added of_node_put(phy_node) thinking about this=20
particular coverity change. But agree it has to be added for
all error path i.e better place would be in xemaclite_of_probe()
error label.

>=20
> > +		return ret;
> > +	}
>=20
> >  		/* Restart auto negotiation */
> >  		bmcr =3D phy_read(lp->phy_dev, MII_BMCR);
> > +		if (bmcr < 0) {
> > +			dev_err(&lp->ndev->dev, "phy_read failed\n");
> > +			phy_disconnect(lp->phy_dev);
> > +			lp->phy_dev =3D NULL;
> > +
> > +			return bmcr;
> > +		}
> >  		bmcr |=3D (BMCR_ANENABLE | BMCR_ANRESTART);
> >  		phy_write(lp->phy_dev, MII_BMCR, bmcr);
>=20
> Does it really make much sense to validate the return value of
> phy_read() but not check any errors from phy_write()s?
Error handling was added for phy_read as it was using return value
and reported by coverity. But yes we in a follow-up patch we
can extend error handling for phy_write as well.
=20