Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3785141pxb; Mon, 9 Nov 2020 23:04:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyVzCP/45IsBEdlwIJ50FGWWUWHq8+hBYLHyuBJTPZbHg90ERLHAQw3I6UBzJKtp72sq49 X-Received: by 2002:a05:6402:1c8e:: with SMTP id cy14mr20230516edb.39.1604991864270; Mon, 09 Nov 2020 23:04:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604991864; cv=none; d=google.com; s=arc-20160816; b=Zs9TnkOrtrMNDGe3idUZ2phbhUJiOdlMOMbHkOhE4TbKuHhMaItWRblKMqfLoH3bs5 Ewmbr3U19CYIr6HBYMCoWc8+9L4QUFwCGw4yXEhLlGYtMm4dGiAVlem4aJAz1Z5LNWlE UDbB7Hjg2DAEpeD1Twy41a5tcQfslQVnDU+R6hLru8ZvQTJ+rEgLqrk83IGlJRiB2X4/ YnHSSxa5/u8E9qKRUuyvEnWvv4ddZPU86cNiIG5aR7FobydlswsbHyaCJHiTT7ijJ6HU XNgvhYUmgy6AUYKq/T5t7XdOE1Jq1SG4n6wL47qMHBn3ewxWwFeavt9Qgubx2jhIETV+ ENag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=lcxk2NIGPVfaoYb1YXbCG/kCN5Buyca2t0w8RiClbbw=; b=cEe0ni/4cttl9NmE3b6FqJoP67eLzYB98jr7rLprEpxueMzBKH4WIUAaaATXJpmW5g qIA2kp8b00AB+Hn/LzHBojdJt90Yl8bSmQLtIlhbbPb7s+D8VpaIaV3eCrh6uKcUbHof X30hNI8tynT1vktSZujcmHL87sJF3tFq72ufgn8t6DBJP+Vn5bhBn5wz9GdwGRn0BSDB HSDYIer4bg+S09U2NQFxOUmU3WTY+soVajuqxN9p8aM1fwq0QYmURNyTOUdh3S6LAczz WXamHVU8ak5JZiOoozSevtUMCmHVby7dgrTRYsS3yFju5Z0k9DB4X9K+XpbOeIlLoWqs 4ocQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=oYs4nMC2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si828625eds.42.2020.11.09.23.04.00; Mon, 09 Nov 2020 23:04:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=oYs4nMC2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731601AbgKJHAY (ORCPT + 99 others); Tue, 10 Nov 2020 02:00:24 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:60368 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgKJHAX (ORCPT ); Tue, 10 Nov 2020 02:00:23 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AA6x5ec053594; Tue, 10 Nov 2020 00:59:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604991545; bh=lcxk2NIGPVfaoYb1YXbCG/kCN5Buyca2t0w8RiClbbw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=oYs4nMC2I0J3x7H3Rkd40cmrnWlhhWnFxApMrg3gyPseiqJAoGNzi+GJbxQUd89Q5 ZgTgcGY904AOVvZMgbekYHO27HmnmqRACD1y+zFtTikfyb56g2AVqSyymmoQEFehAZ Cj/D5kX433AwKEPrvadI8woJveYrhli37/Dv/ldM= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AA6x5iR040123 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Nov 2020 00:59:05 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 10 Nov 2020 00:59:04 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 10 Nov 2020 00:59:05 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AA6x2vA122096; Tue, 10 Nov 2020 00:59:03 -0600 Subject: Re: [PATCH] ASoC: pcm512x: Add support for data formats RJ and LJ To: Kirill Marinushkin , Mark Brown , Takashi Iwai , Liam Girdwood CC: Matthias Reichl , Kuninori Morimoto , , References: <20201109212133.25869-1-kmarinushkin@birdec.com> From: Peter Ujfalusi Message-ID: <690508c7-7029-6781-a1a2-0609e37cb9e6@ti.com> Date: Tue, 10 Nov 2020 08:59:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <20201109212133.25869-1-kmarinushkin@birdec.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2020 23.21, Kirill Marinushkin wrote: > Currently, pcm512x driver supports only I2S data format. > This commit adds RJ and LJ as well. > > I don't expect regression WRT existing sound cards, because: > > * default value in corresponding register of pcm512x codec is 0 == I2S > * existing in-tree sound cards with pcm512x codec are configured for I2S > * i don't see how existing off-tree sound cards with pcm512x codec could be > configured differently - it would not work > * tested explicitly, that there is no regression with Raspberry Pi + > sound card `sound/soc/bcm/hifiberry_dacplus.c` > > Signed-off-by: Kirill Marinushkin > Cc: Mark Brown > Cc: Takashi Iwai > Cc: Liam Girdwood > Cc: Matthias Reichl > Cc: Kuninori Morimoto > Cc: Peter Ujfalusi > Cc: alsa-devel@alsa-project.org > Cc: linux-kernel@vger.kernel.org > --- > sound/soc/codecs/pcm512x.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c > index 8153d3d01654..c6e975fb4a43 100644 > --- a/sound/soc/codecs/pcm512x.c > +++ b/sound/soc/codecs/pcm512x.c > @@ -1167,6 +1167,7 @@ static int pcm512x_hw_params(struct snd_pcm_substream *substream, > struct snd_soc_component *component = dai->component; > struct pcm512x_priv *pcm512x = snd_soc_component_get_drvdata(component); > int alen; > + int afmt; > int gpio; > int clock_output; > int master_mode; > @@ -1195,6 +1196,22 @@ static int pcm512x_hw_params(struct snd_pcm_substream *substream, > return -EINVAL; > } > > + switch (pcm512x->fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > + case SND_SOC_DAIFMT_I2S: > + afmt = PCM512x_AFMT_I2S; > + break; > + case SND_SOC_DAIFMT_RIGHT_J: > + afmt = PCM512x_AFMT_RTJ; > + break; > + case SND_SOC_DAIFMT_LEFT_J: > + afmt = PCM512x_AFMT_LTJ; > + break; > + default: > + dev_err(component->dev, "unsupported DAI format: 0x%x\n", > + pcm512x->fmt); > + return -EINVAL; > + } > + The bus format and > switch (pcm512x->fmt & SND_SOC_DAIFMT_MASTER_MASK) { > case SND_SOC_DAIFMT_CBS_CFS: > ret = regmap_update_bits(pcm512x->regmap, the clock generation role should be set in pcm512x_set_fmt(), in that way you can deny specific setups earlier. I would also add DSP_A and DSP_B modes at the same time, DSP_A would need a write of 1 to register 41 (PCM512x_I2S_2, offset = 1), other formats should set the offset to 0. > @@ -1236,6 +1253,13 @@ static int pcm512x_hw_params(struct snd_pcm_substream *substream, > return ret; > } > > + ret = regmap_update_bits(pcm512x->regmap, PCM512x_I2S_1, > + PCM512x_AFMT, afmt); > + if (ret != 0) { > + dev_err(component->dev, "Failed to set data format: %d\n", ret); > + return ret; > + } > + > if (pcm512x->pll_out) { > ret = regmap_write(pcm512x->regmap, PCM512x_FLEX_A, 0x11); > if (ret != 0) { > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki