Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: tjJgco/qruJ3m2QJa7CgDatar9rXeQJQeNiCPOM1cg8gsI6+FtxVJsnquuXc89PO68NhkbXIif
 0yaIHXFBM8mgWDlxwOKGKngtYX7vh9BEFJFYoWAU9buLncVSwN87ws5co27gyy/seQHgaLUNi1
 WdO3y/xobB0zMepU7bX6F0mFtYukyJG7WsTZ0W+AICGpTUaHz7cDZzraSoBxODLWgV68qTN46m
 01ZCQQisxI6q6B2xF2IQo/GWTsjj3PRT2IXMNNPX69orW9ZvN9e6lnnvI4tZ+bmbx26IW0SzY0
 sFU=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] scsi: ufshcd: fix missing destroy_workqueue()
Thread-Topic: [PATCH v2] scsi: ufshcd: fix missing destroy_workqueue()
Thread-Index: AQHWtzRZqrl014t+eky/0Sg1gjmKMKnA/ekw
Date:   Tue, 10 Nov 2020 07:52:34 +0000
Message-ID: <DM6PR04MB6575DD8902438750B2C2811CFCE90@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201110074223.41280-1-miaoqinglang@huawei.com>
In-Reply-To: <20201110074223.41280-1-miaoqinglang@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e3df8e34-3f32-45b8-a2e7-08d8854d95b9
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 07:52:34.3424
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nG02SNZ4WPcmTlaI9e05nm0LsHvDRIrwvjJiidqGv65WiCgpRqqsuhLYzSAlEcFPRjmDaWw/Nkpi3H3+1x4zxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1133
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> Add the missing destroy_workqueue() before return from
> ufshcd_init in the error handling case as well as in
> ufshcd_remove.
>=20
> Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and oth=
er
> error recovery paths")
> Suggested-by: Avri Altman <Avri.Altman@wdc.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  v2: consider missing destroy_workqueue ufshcd_remove either.
>=20
>  drivers/scsi/ufs/ufshcd.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index b8f573a02713..adbdda4f556b 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8906,6 +8906,7 @@ void ufshcd_remove(struct ufs_hba *hba)
>         blk_mq_free_tag_set(&hba->tmf_tag_set);
>         blk_cleanup_queue(hba->cmd_queue);
>         scsi_remove_host(hba->host);
> +       destroy_workqueue(hba->eh_wq);
>         /* disable interrupts */
>         ufshcd_disable_intr(hba, hba->intr_mask);
>         ufshcd_hba_stop(hba);
> @@ -9206,6 +9207,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem
> *mmio_base, unsigned int irq)
>  exit_gating:
>         ufshcd_exit_clk_scaling(hba);
>         ufshcd_exit_clk_gating(hba);
> +       destroy_workqueue(hba->eh_wq);
>  out_disable:
>         hba->is_irq_enabled =3D false;
>         ufshcd_hba_exit(hba);
> --
> 2.23.0