Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3841698pxb; Tue, 10 Nov 2020 01:07:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+J2qjsNUEV8ReHGLSni+HfGun8bqaZOW/D4N0R1jDKKQCIIe7BGrqYRJhE7yoEZTV1Kdm X-Received: by 2002:aa7:c2d7:: with SMTP id m23mr20041741edp.230.1604999234175; Tue, 10 Nov 2020 01:07:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604999234; cv=none; d=google.com; s=arc-20160816; b=GAAR5q/70qfwzbLQ24vlf954yqhvPXOcB+PFN2LNy7+UbPiVYEWEco/2SKLwt1Q7Y3 E2hmBl2KsNYsACumUubuCzJHBWlGFDyzOREy6+mGzeb4NY31OVZ+pTrwtNgzKo+ZIVI9 AIt1L0xE/zD+YerqnvXti1Z2VGjWm8Bg6c7ROdQRqxYKFK4M2fN7o2YqVE0gRM0hNOu7 1X+Djo/fpujjO5cbJlG9Seruge/truRv53mTJB3HMC3eR3QxVQ2RUe+bEAkqWpniL7i5 XBiVz30ydISvGAVRJh5qhlBNBrnQ3kFcN02K4Zts1zp8pPcgqE6VZxU7H8/1unTheTac e2aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=TcjlQm8mw5u8OBeREeShW2+Iq8lK2zjpkTbtg2I0Y5E=; b=sE5Z/sX5i8+OGW/nMUupLsM+VfpF6Y0gVrNWyJ5E0yO5ZVR1IASH5VDnC5Y/GDx4VP IOZLhebzDW/Ur5WuyfTBzjuBxxK0eYzGAql9HsQzPUVwPOjjfy1crG2hSvuFsTOm3mjF DdjEaJr7e9zOtaFTFoNZ21FQMnQBYx/fcv+efjW80sOY+NgGWk7V/+k0yrzygiAkjnMu gaC2KUS3QNXt3NI4QsHfGeMQWgub+vAFmaSNcy2uhkeFSwI7Ki68c+OYY49BaYqxVgLD AUEM9yv58ms7+8WYUBdivB6Kv7BTy+fXJ3ORPYzXsQHHP88lisGeVJYosyYb4mUsXQgD Dy/w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si8867325ejg.491.2020.11.10.01.06.50; Tue, 10 Nov 2020 01:07:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbgKJJCx (ORCPT + 99 others); Tue, 10 Nov 2020 04:02:53 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:49040 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgKJJCv (ORCPT ); Tue, 10 Nov 2020 04:02:51 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id B0E9C2003B; Tue, 10 Nov 2020 10:02:48 +0100 (CET) Date: Tue, 10 Nov 2020 10:02:47 +0100 From: Sam Ravnborg To: Lee Jones Cc: Alex Deucher , David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header Message-ID: <20201110090247.GB2027451@ravnborg.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-16-lee.jones@linaro.org> <20201110072242.GF2063125@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110072242.GF2063125@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=m2FF2UwdyuouuLPjHqMA:9 a=CjuIK1q_8ugA:10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, > > the *d.h headers are supposed to just be hardware definitions. I'd > > prefer to keep driver stuff out of them. > > That's fine (I did wonder if that were the case). > > I need an answer from you and Sam whether I can create new headers. > > For me, it is the right thing to do. Please follow the advice of Alex for the radeon driver. Sam