Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "balbi@kernel.org" <balbi@kernel.org>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>
Subject: Re: [PATCH v2 01/10] usb: cdns3: Add support for DRD CDNSP
Thread-Topic: [PATCH v2 01/10] usb: cdns3: Add support for DRD CDNSP
Thread-Index: AQHWtDJHpjDqwoW9QUS5Pv6rgaf5tanBGHYA
Date:   Tue, 10 Nov 2020 09:04:28 +0000
Message-ID: <20201110090400.GA22481@b29397-desktop>
References: <20201106114300.1245-1-pawell@cadence.com>
 <20201106114300.1245-2-pawell@cadence.com>
In-Reply-To: <20201106114300.1245-2-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E42618A9350679448030016D2FFDF815@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2636498c-c62d-4c8a-6872-08d88557a193
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 09:04:29.0205
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fOBcWH04GTJs6qstun9tpEfvEQMngWHScQv7NaIapjCLNsoxWReESunCf1RZQuY32C8069nsGcswAgg36xZh4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4492
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-11-06 12:42:51, Pawel Laszczak wrote:
> - * Value of the strap pins.
> + * Value of the strap pins for:
> + * CDN3:

%/CDN3/CDNS3

Peter
>   * 000 - no default configuration
>   * 010 - Controller initiall configured as Host
>   * 100 - Controller initially configured as Device
> + * CDNSP:
> + * 000 - No default configuration.
> + * 010 - Controller initiall configured as Host.
> + * 100 - Controller initially configured as Device.
>   */
>  #define OTGSTS_STRAP(p)			(((p) & GENMASK(14, 12)) >> 12)
>  #define OTGSTS_STRAP_NO_DEFAULT_CFG	0x00
>  #define OTGSTS_STRAP_HOST_OTG		0x01
>  #define OTGSTS_STRAP_HOST		0x02
>  #define OTGSTS_STRAP_GADGET		0x04
> +#define OTGSTS_CDNSP_STRAP_HOST		0x01
> +#define OTGSTS_CDNSP_STRAP_GADGET	0x02
> +
>  /* Host mode is turned on. */
> -#define OTGSTS_XHCI_READY		BIT(26)
> +#define OTGSTS_CDNS3_XHCI_READY		BIT(26)
> +#define OTGSTS_CDNSP_XHCI_READY		BIT(27)
> +
>  /* "Device mode is turned on .*/
> -#define OTGSTS_DEV_READY		BIT(27)
> +#define OTGSTS_CDNS3_DEV_READY		BIT(27)
> +#define OTGSTS_CDNSP_DEV_READY		BIT(26)
> =20
>  /* OTGSTATE- bitmasks */
>  #define OTGSTATE_DEV_STATE_MASK		GENMASK(2, 0)
> @@ -152,6 +194,8 @@ struct cdns3_otg_common_regs {
>  #define OVERRIDE_IDPULLUP		BIT(0)
>  /* Only for CDNS3_CONTROLLER_V0 version */
>  #define OVERRIDE_IDPULLUP_V0		BIT(24)
> +/* Vbusvalid/Sesvalid override select. */
> +#define OVERRIDE_SESS_VLD_SEL		BIT(10)
> =20
>  /* PHYRST_CFG - bitmasks */
>  #define PHYRST_CFG_PHYRST_A_ENABLE     BIT(0)
> @@ -170,6 +214,5 @@ int cdns3_drd_gadget_on(struct cdns3 *cdns);
>  void cdns3_drd_gadget_off(struct cdns3 *cdns);
>  int cdns3_drd_host_on(struct cdns3 *cdns);
>  void cdns3_drd_host_off(struct cdns3 *cdns);
> -int cdns3_set_mode(struct cdns3 *cdns, enum usb_dr_mode mode);
> =20
>  #endif /* __LINUX_CDNS3_DRD */
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=