Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp3856104pxb; Tue, 10 Nov 2020 01:37:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxs1YqxM6miuVNijpXc7jiyjuoRc0xjYtoq2V+kuxcjH0jugztLTUtNm+vlb+UJL5jtT9PR X-Received: by 2002:a50:cf46:: with SMTP id d6mr20407362edk.356.1605001026789; Tue, 10 Nov 2020 01:37:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605001026; cv=none; d=google.com; s=arc-20160816; b=LLiuNm21+u5XNjXz505Kt3Cebm+Pq8vNLAqFJEtImWtg8woCpIJeHIChV4ArMuv/Om wBOIBxtdjO9R7oZ/YikorJ2rw8z98VeCmBweGZ1gWeq9npT6T3+r5BftUCcG01b9oOfZ 20iHGJdG5sJBlktPLbVhJ7oJ2Bk4fVla2gzFu/PYNry3CYAXYgIfXI4J75smVNngxSTy UofrU+0QbgusrnlaaUxOANY/TED0fUriicYJmDjo98BfWAUZ3fIp2lGHm8yoaDUK6zEw JgF1d6tOIeevBy23zckrTDQ2DjZez1dywm8cWrYDySzSppiKepI3CGRpF+gkHo9oWebB 15YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:to:from; bh=hKJSmk8SMY9A1lvZxxA1RX1aMk3TOSbYTywlif4f/RM=; b=wvedqekRD4o7BqQeOPIBsF8vfs853W+UwBlmd8i8DsfHZJI69AK5gtoRKZcfrnRtzU L3gRsXYD5LgK978ssKU6SAbKzYpSF3aM2meFozK3FPbz+Ibx/ZAoPVx8n0W1g+hWkflI yryCy2krwHC8fmtoBGqEfuI4f++NAfNrR2Rcur7czrOu5GqPZAcqgvjm84c8/OXzSnl0 8es4YwiwFbcL4FOzOWMzdv3Rw5eaNyLbjsUHNxlHRCmNMm+a5CILngZLkAse973hK6a5 9mfNziEUHHLtvJq7FuoFICSV3ZMCiqMPJC/n97+e5UdvWFwGD3SUdwd2O0wjWzVKJQpb +ftQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p9si8882587edm.38.2020.11.10.01.36.42; Tue, 10 Nov 2020 01:37:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgKJJfW (ORCPT + 99 others); Tue, 10 Nov 2020 04:35:22 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7166 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgKJJfV (ORCPT ); Tue, 10 Nov 2020 04:35:21 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CVjQ75Sjwz15Sl2; Tue, 10 Nov 2020 17:35:11 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 10 Nov 2020 17:35:16 +0800 From: Tian Tao To: , , , Subject: [PATCH] rtc: cpcap: Fix missing IRQF_ONESHOT as only threaded handler Date: Tue, 10 Nov 2020 17:35:47 +0800 Message-ID: <1605000947-32882-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coccinelle noticed: drivers/rtc/rtc-cpcap.c:271:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT drivers/rtc/rtc-cpcap.c:287:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Tian Tao --- drivers/rtc/rtc-cpcap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c index 800667d..38d576b 100644 --- a/drivers/rtc/rtc-cpcap.c +++ b/drivers/rtc/rtc-cpcap.c @@ -269,7 +269,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) rtc->alarm_irq = platform_get_irq(pdev, 0); err = devm_request_threaded_irq(dev, rtc->alarm_irq, NULL, - cpcap_rtc_alarm_irq, IRQF_TRIGGER_NONE, + cpcap_rtc_alarm_irq, + IRQF_TRIGGER_NONE | IRQF_ONESHOT, "rtc_alarm", rtc); if (err) { dev_err(dev, "Could not request alarm irq: %d\n", err); @@ -285,7 +286,8 @@ static int cpcap_rtc_probe(struct platform_device *pdev) */ rtc->update_irq = platform_get_irq(pdev, 1); err = devm_request_threaded_irq(dev, rtc->update_irq, NULL, - cpcap_rtc_update_irq, IRQF_TRIGGER_NONE, + cpcap_rtc_update_irq, + IRQF_TRIGGER_NONE | IRQF_ONESHOT, "rtc_1hz", rtc); if (err) { dev_err(dev, "Could not request update irq: %d\n", err); -- 2.7.4