Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 12:43:09 +0100
From:   Jesper Dangaard Brouer <jbrouer@redhat.com>
To:     John Fastabend <john.fastabend@gmail.com>
Cc:     Alex Shi <alex.shi@linux.alibaba.com>, davem@davemloft.net,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/xdp: remove unused macro REG_STATE_NEW
Message-ID: <20201110124309.6240df73@carbon>
In-Reply-To: <5fa9b850d6de5_8c0e2089d@john-XPS-13-9370.notmuch>
References: <1604641431-6295-1-git-send-email-alex.shi@linux.alibaba.com>
        <20201106171352.5c51342d@carbon>
        <3d39a08d-2e50-efeb-214f-0c7c2d1605d7@linux.alibaba.com>
        <5fa9b850d6de5_8c0e2089d@john-XPS-13-9370.notmuch>
Organization: Red Hat Inc.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 09 Nov 2020 13:44:48 -0800
John Fastabend <john.fastabend@gmail.com> wrote:

> Alex Shi wrote:
> >=20
> >=20
> > =E5=9C=A8 2020/11/7 =E4=B8=8A=E5=8D=8812:13, Jesper Dangaard Brouer =E5=
=86=99=E9=81=93: =20
> > > Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero.
> > > But it is true that it is technically not directly used or referenced.
> > >=20
> > > It is mentioned in a comment, so please send V2 with this additional =
change: =20
> >=20
> > Hi Jesper,
> >=20
> > Thanks a lot for comments. here is the v2:
> >=20
> > From 2908d25bf2e1c90ad71a83ba056743f45da283e8 Mon Sep 17 00:00:00 2001
> > From: Alex Shi <alex.shi@linux.alibaba.com>
> > Date: Fri, 6 Nov 2020 13:41:58 +0800
> > Subject: [PATCH v2] net/xdp: remove unused macro REG_STATE_NEW
> >=20
> > To tame gcc warning on it:
> > net/core/xdp.c:20:0: warning: macro "REG_STATE_NEW" is not used
> > [-Wunused-macros]
> > And change related comments as Jesper Dangaard Brouer suggested.
> >=20
> > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> > --- =20
>=20
> >  net/core/xdp.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >=20
> > diff --git a/net/core/xdp.c b/net/core/xdp.c
> > index 48aba933a5a8..0df5ee5682d9 100644
> > --- a/net/core/xdp.c
> > +++ b/net/core/xdp.c
> > @@ -19,7 +19,6 @@
> >  #include <trace/events/xdp.h>
> >  #include <net/xdp_sock_drv.h>
> > =20
> > -#define REG_STATE_NEW		0x0
> >  #define REG_STATE_REGISTERED	0x1
> >  #define REG_STATE_UNREGISTERED	0x2
> >  #define REG_STATE_UNUSED	0x3 =20
>=20
> I think having the define there makes it more readable and clear what
> the zero state is. But if we run with unused-macros I guess its even
> uglier to try and mark it with unused attribute.

I  agree having the define there makes it more readable and clear what
the zero state is.

We can also add code that replace the comment, that check/use these
defines.  It is slow-path code, so it doesn't hurt to add this extra
code.  Generally I find it strange to "fix" these kind of warnings, but
also don't care that we do fix them if it helps someone else spot code
where it actually matters.

> Acked-by: John Fastabend <john.fastabend@gmail.com>
>=20
> > @@ -175,7 +174,7 @@ int xdp_rxq_info_reg(struct xdp_rxq_info *xdp_rxq,
> >  		return -ENODEV;
> >  	}
> > =20
> > -	/* State either UNREGISTERED or NEW */
> > +	/* State either UNREGISTERED or zero */
> >  	xdp_rxq_info_init(xdp_rxq);
> >  	xdp_rxq->dev =3D dev;
> >  	xdp_rxq->queue_index =3D queue_index;
> > --=20
> > 1.8.3.1
> >  =20
>=20
>=20


--=20
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer