Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201110134101.434928-1-arch0.zheng@gmail.com>
In-Reply-To: <20201110134101.434928-1-arch0.zheng@gmail.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 10 Nov 2020 14:49:15 +0100
Message-ID: <CAKfTPtD_SKKWTr=Q7Y83XQ_BG7ptSDgB1=jOsfcczXULhae5sQ@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Remove the redundant critical section
To:     Qi Zheng <arch0.zheng@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 10 Nov 2020 at 14:41, Qi Zheng <arch0.zheng@gmail.com> wrote:
>
> Now there is nothing in the critical section, so remove it.

https://lkml.org/lkml/2020/10/30/689

>
> Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
> ---
>  kernel/sched/fair.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 52cacfc62922..06c4f3430e95 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
>                 return;
>
>         distribute_cfs_runtime(cfs_b);
> -
> -       raw_spin_lock_irqsave(&cfs_b->lock, flags);
> -       raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
>  }
>
>  /*
> --
> 2.25.1
>