Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 2UpuuUnYgUkZJm1lIdtDtQI6Nc9VMCgtPWEGL+taI65/AbhHnx5hg+EpDkToZ63U1KJHeQIBrn
 9VV2ZpRlRWKg==
IronPort-SDR: lxYSFEGxy4Km5kAA/xUqloobFP4zJ/MpiwZQwkbSbDDKz//CYOgtcl5OCQVvtX6NgEGVR/nGzO
 b/oc46MGYCbQ==
Date:   Tue, 10 Nov 2020 16:27:50 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        David Laight <David.Laight@aculab.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap
Message-ID: <20201110142750.GU4077@smile.fi.intel.com>
References: <20201110123406.3261-1-brgl@bgdev.pl>
 <20201110123406.3261-7-brgl@bgdev.pl>
 <20201110142624.GT4077@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201110142624.GT4077@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 10, 2020 at 04:26:24PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 10, 2020 at 01:34:05PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > 
> > We can simplify the code in gpio-exar by using regmap. This allows us to
> > drop the mutex (regmap provides its own locking) and we can also reuse
> > regmap's bit operations instead of implementing our own update function.
> 
> ...
> 
> > +	/*
> > +	 * We don't need to check the return values of mmio regmap operations (unless
> > +	 * the regmap has a clock attached which is not the case here).
> > +	 */
> > +	exar_gpio->regs = devm_regmap_init_mmio(dev, p, &exar_regmap_config);
> > +	if (IS_ERR(exar_gpio->regs))
> > +		return PTR_ERR(exar_gpio->regs);
> >  
> >  	index = ida_alloc(&ida_index, GFP_KERNEL);
> > -	if (index < 0) {
> > -		ret = index;
> > -		goto err_mutex_destroy;
> > -	}
> > +	if (index < 0)
> > +		return index;
> 
> And below you effectively use p as regmap!
> That's what renaming of variable regs -> regmap or map can easily reveal.
> 
> 	exar_gpio->regs = p;

Jan, if you remove this line, does it help?

-- 
With Best Regards,
Andy Shevchenko