Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4042402pxb; Tue, 10 Nov 2020 06:38:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRchVqPQaSriHrezy7Co4ndRI5ecwOHJu/VcUEnqTVMZLnJN/ToeDOULIYlb9NEKFUUxrt X-Received: by 2002:aa7:c508:: with SMTP id o8mr21453538edq.339.1605019131678; Tue, 10 Nov 2020 06:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605019131; cv=none; d=google.com; s=arc-20160816; b=SmYPESY4y0XaSiPJjCP5qipyq7xr6io6djGCNNpJDhMniAJ4114Mpqfcttx6OoDr6f rd/NyPwQ7lit1J4jjZu1cCqUZsqRF7xDO9RNqkGgLprf8rdqdEXwB3tv3wRczxTz+A5+ C93jn0V5KwDAs8DVHEOnWg8zVlA2SethEppD/1/PQahMk4ukZqCgWpwkzzRCtJkZo+ev QkkJ6MM4ulBntAicmAQISbVdCyPEcL6XNbEIgixWhi8dOb4rrRYaH/g/KjeBND/WKTpE 7yzpy+IXYfE8deOgxXdUooFhP+esyom+wo68guOBCZ3qSY5nciF+FtJNADibv6u/zQW3 p9WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=xRIypW99dydWxym9olIbQVS6DGC1I29UdjlZ6dRFIRg=; b=GFbFf8Osr2gCNH2eHe8YBqgNqt/B5pvmTHgzmRMANHKm84bdpEQyCsrKbwLzx8FtsR Y0JQjpbpY0V/KxlvbMG91w5VNmu1J7QDxMhNKVRDtEeQO3uFvxxDzVhyQgoMhQrBu86B 1Y6UqEVXDlYq36FxhwJGu91Rdg6LKobQ4N0DvPpGHAK2g+YQw2SLO0JVQnkNziJz5Lv6 1QYcup/ZqtPsveFHeKDfcU1o8YGw+Vu6ETzvAdi471jqfr6x5A3+c/7T2ZW/p/cjAUay rFqQzHGcl6nUCPMZ6rwBQtFJjsK13V1+QlR5xstRphGXMYxILYxvZt+6PVbGAIOWczrY 5GyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=lYfMzHlM; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si9173257ejx.264.2020.11.10.06.38.28; Tue, 10 Nov 2020 06:38:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@linutronix.de header.s=2020 header.b=lYfMzHlM; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730099AbgKJOef (ORCPT + 99 others); Tue, 10 Nov 2020 09:34:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbgKJOef (ORCPT ); Tue, 10 Nov 2020 09:34:35 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E3F8C0613CF for ; Tue, 10 Nov 2020 06:34:35 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1605018873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRIypW99dydWxym9olIbQVS6DGC1I29UdjlZ6dRFIRg=; b=lYfMzHlMG/WWVDXKfMCn2LvyjX+G8obWVeM6tdD9Aa552o6/w1BVvEOKWPzEuDUgowBIsN QF+ClfmH5IzvWUD7EKMVVGcyeIfQw4ZlL3Ll9au9GjdChx+D/pN1a0g4p8dvJCDvXROsqA VmTro+v54UJg9xlauCiW+91mDYmI59tJNe4Eqz2NZ31fJ2a/hZpknu3nwi06lig5pMTAMN YYk1hQXUkPWpja9CIZe3uPF/W2N1KoUiZW+V3cce8a9LG3PPuvF/zmpBGMxE3LVQ2Wn22H +WKJUzXVw8sup+q4yZDTny4l/B5vASkrML53HmR5BxxmiAWyO2UC3lUWiCXr6w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1605018873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRIypW99dydWxym9olIbQVS6DGC1I29UdjlZ6dRFIRg=; b=dTZmQVWhnTcXky6bOTYSOcs4vrYT+9XIHQ1oHaLh1bR+rKos1SeIp7rCt7Q+xZOJYJPTV2 AJ/BYxtEednlJQCg== To: Borislav Petkov , Tom Lendacky Cc: linux-kernel@vger.kernel.org, David Woodhouse , x86 , Qian Cai Subject: Re: [tip: x86/apic] x86/io_apic: Cleanup trigger/polarity helpers In-Reply-To: <20201110061046.GA7290@nazgul.tnic> References: <20201024213535.443185-20-dwmw2@infradead.org> <160397373817.397.3191135882528008704.tip-bot2@tip-bot2> <20201110061046.GA7290@nazgul.tnic> Date: Tue, 10 Nov 2020 15:34:32 +0100 Message-ID: <87d00lgu13.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10 2020 at 07:10, Borislav Petkov wrote: > On Mon, Nov 09, 2020 at 05:15:03PM -0600, Tom Lendacky wrote: >> [ 105.325371] hpet: Lost 9601 RTC interrupts >> [ 105.485766] hpet: Lost 9600 RTC interrupts >> [ 105.639182] hpet: Lost 9601 RTC interrupts >> [ 105.792155] hpet: Lost 9601 RTC interrupts >> [ 105.947076] hpet: Lost 9601 RTC interrupts >> [ 106.100876] hpet: Lost 9600 RTC interrupts >> [ 106.253444] hpet: Lost 9601 RTC interrupts >> [ 106.406722] hpet: Lost 9601 RTC interrupts >> >> preventing the system from booting. I bisected it to this commit. > > I bisected it to the exact same thing too, on an AMD laptop, after seeing what > you're seeing. Bah. I'm a moron. --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -809,9 +809,9 @@ static bool irq_is_level(int idx) case MP_IRQTRIG_DEFAULT: /* * Conforms to spec, ie. bus-type dependent trigger - * mode. PCI defaults to egde, ISA to level. + * mode. PCI defaults to level, ISA to edge. */ - level = test_bit(bus, mp_bus_not_pci); + level = !test_bit(bus, mp_bus_not_pci); /* Take EISA into account */ return eisa_irq_is_level(idx, bus, level); case MP_IRQTRIG_EDGE: