Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4059139pxb; Tue, 10 Nov 2020 07:02:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqGCJxkO9MzzBYspxxzDsSlI9wzUk5jwfBzJNkuYMO/IuGSeQWs1MvdFhHHxfe3Vy2yY/+ X-Received: by 2002:a17:906:b003:: with SMTP id v3mr13199587ejy.290.1605020568746; Tue, 10 Nov 2020 07:02:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605020568; cv=none; d=google.com; s=arc-20160816; b=dvlrOzi6JvlVwMVe0apk9J7ekMUQNf30cZAfib0OdTB5l9qBI4ufOb3FivK1DfPKtC 9Ssdo3o2JBIERBkj4EfsMIfBOtYJrpX2iDLn4imoEwXRnnslk2k0KtCRuLE1lptP2paw dMB1+IBlLVfpYaN8Q+h57NaR5IssDZ/HO+6GLWtIFpULGleDi7B0kAEWXO5VUoJsiHPd 1kO4dBs7uKiOOe8zOB7rH2y2cTLQ57ZIpDJxlRlne0r6c7ywq8rjVCfkx96GAPRh68f8 bHvxMHdkquVdZ8M410xKkvrGs2s3bTXSHQGFHU+qNOWpGffVYPFy+Tqfk51KH+XjZIeE T9iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=q/zo1xi8KnfAPyrwx2ONuY1YRWu1hZnQju/SPad0KHE=; b=g+C5G78wlRrus2PQIPV7Q8Qdede77fOxhO9cdRe8sSbMzlCBnge3znCnBy8+RN523h GIsWRYr4WLHPpiJaUPBmYCgyHYEv4bXPhQrTovWTdwU5+fT70UOg6fyl6YqFEhDgO6xf dIUxkLOalW/3yxi3ANaISWc9yb7t41VycNMXgXJRGXQXGlKiGQsMejnW9BLw/h9pLhRU SOaZDhp3XfIk7+3a6yCNgbFhIPunEeRXXso5wjEHkZGllpys6B/mQmwM6zbVMkM4R3Oy x+Stkh93C5pO/W891r35wOlCV+jX06inAUwS3LU1m0SVjYMXWtutQzYSrKQuhgbYoTvT Dc8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si9038675eje.696.2020.11.10.07.02.21; Tue, 10 Nov 2020 07:02:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731086AbgKJPAw (ORCPT + 99 others); Tue, 10 Nov 2020 10:00:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:16060 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731054AbgKJPAv (ORCPT ); Tue, 10 Nov 2020 10:00:51 -0500 IronPort-SDR: KUJF6RES29JEwO8GNmj0G3+9RfsOV0WNV9XzypfBcjDD+C+xfqusOdCN4r2Pq1Yl57dkLfaRiU rRK4SL1RhWmg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="156990559" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="156990559" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:00:43 -0800 IronPort-SDR: 0m+sLG7EaSBtlxIOGydFu1MSzxEGYua1iyjNhe/OIQVXozS4eZ8mzpYzjSPOymLLaXQJCkdVFl oPvRg773uhNA== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="327706939" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:00:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kcV9T-005VNY-0j; Tue, 10 Nov 2020 17:01:43 +0200 Date: Tue, 10 Nov 2020 17:01:43 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Jan Kiszka , Bartosz Golaszewski , Linus Walleij , David Laight , linux-gpio , LKML Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap Message-ID: <20201110150143.GV4077@smile.fi.intel.com> References: <20201110123406.3261-1-brgl@bgdev.pl> <20201110123406.3261-7-brgl@bgdev.pl> <20201110142624.GT4077@smile.fi.intel.com> <20201110142750.GU4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 03:52:00PM +0100, Bartosz Golaszewski wrote: > On Tue, Nov 10, 2020 at 3:50 PM Jan Kiszka wrote: > > On 10.11.20 15:30, Bartosz Golaszewski wrote: ... > > Removing the line that Andy found made things work here. And switching > > to 16 for reg_bits didn't make things worse again. > > > > Jan > > Alright! I'll send a v4 with these things fixed then. Hold on, the registers are 16-bit wide, but their halves are sparsed! So, I guess 8 and 8 with helpers to get hi and lo parts are essential. -- With Best Regards, Andy Shevchenko