Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201105111823.1613337-1-anders.roxell@linaro.org> <20201106151240.GA45829@kozik-lap>
In-Reply-To: <20201106151240.GA45829@kozik-lap>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Tue, 10 Nov 2020 16:14:01 +0100
Message-ID: <CADYN=9+FZgm0ufR-Gdqh0b7dht0KiDxEm8S+d5neFYmJQtzPuA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: freescale: fix typo Makefile
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 6 Nov 2020 at 16:12, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Nov 05, 2020 at 12:18:23PM +0100, Anders Roxell wrote:
> > While trying to do 'make dtbs_install' the following error shows up
> >
> > make[3]: *** No rule to make target
> >   '/srv/src/kernel/next/out/obj-arm64-next-20201105/dtbsinstall/freescale/imx8mm-kontron-n801x-s.dts',
> >   needed by '__dtbs_install'.
> > make[3]: Target '__dtbs_install' not remade because of errors.
> > make[2]: *** [/srv/src/kernel/bisecting/scripts/Makefile.dtbinst:34:
> >   arch/arm64/boot/dts/freescale] Error 2
> > make[2]: Target '__dtbs_install' not remade because of errors.
> > make[1]: *** [/srv/src/kernel/bisecting/Makefile:1344: dtbs_install]
> >   Error 2
> > make: *** [Makefile:185: __sub-make] Error 2
> > make: Target 'dtbs_install' not remade because of errors.
>
> Don't paste unrelated messages and don't wrap too early ("Error 2"
> should not be after new line). This blob is not useful at all.
>
> Keep only first two lines, all rest is meaningless.

Thank you for your review Krzysztof, I'll do that.

>
> >
> > Fix typo in imx8mm-kontron-n801x-s.dts change file ending to *.dtb
> >
> > Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> You need to CC the maintainers of platform. Unfortunately Makefile is
> not included, so point to the DTS file to get the proper folks and
> mailing lists.

Ok, I'll send out a v2 shortly.

Cheers,
Anders