Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 16:12:57 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Like Xu <like.xu@linux.intel.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Kan Liang <kan.liang@linux.intel.com>, luwei.kang@intel.com,
        Thomas Gleixner <tglx@linutronix.de>, wei.w.wang@intel.com,
        Tony Luck <tony.luck@intel.com>,
        Stephane Eranian <eranian@google.com>,
        Mark Gross <mgross@linux.intel.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v2 00/17] KVM: x86/pmu: Add support to enable Guest
 PEBS via DS
Message-ID: <20201110151257.GP2611@hirez.programming.kicks-ass.net>
References: <20201109021254.79755-1-like.xu@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201109021254.79755-1-like.xu@linux.intel.com>
Precedence: bulk

On Mon, Nov 09, 2020 at 10:12:37AM +0800, Like Xu wrote:
> The Precise Event Based Sampling(PEBS) supported on Intel Ice Lake server
> platforms can provide an architectural state of the instruction executed
> after the instruction that caused the event. This patch set enables the
> the PEBS via DS feature for KVM (also non) Linux guest on the Ice Lake.
> The Linux guest can use PEBS feature like native:
> 
>   # perf record -e instructions:ppp ./br_instr a
>   # perf record -c 100000 -e instructions:pp ./br_instr a
> 
> If the counter_freezing is not enabled on the host, the guest PEBS will
> be disabled on purpose when host is using PEBS facility. By default,
> KVM disables the co-existence of guest PEBS and host PEBS.

Uuhh, what?!? counter_freezing should never be enabled, its broken. Let
me go delete all that code.