Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 08:34:02 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        Shakeel Butt <shakeelb@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH] mm: memcg/slab: enable slab memory accounting atomically
Message-ID: <20201110163402.GC2612097@carbon.dhcp.thefacebook.com>
References: <20201110010615.1273043-1-guro@fb.com>
 <20201110152143.GA842337@cmpxchg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201110152143.GA842337@cmpxchg.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:a643) by MWHPR07CA0017.namprd07.prod.outlook.com (2603:10b6:300:116::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Tue, 10 Nov 2020 16:34:08 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d5677ec9-a8c7-45a9-f6ed-08d885967335
X-MS-TrafficTypeDiagnostic: BYAPR15MB3125:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB3125B33A0BA4AB65A0737B52BEE90@BYAPR15MB3125.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:1284;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 96a7Au+HBki/aVSyfRAPX1vmQl2MFkjZWq3lNu7qWyKo7RyY7f7elAupBunG8nP6jqvS71MefsHUFevjMoXZ0yHGUx0Ygetcsxa5xjXoLvNIRr8uEeGc8ksso/JY6NqAo9GMvG+9hnh81R4796+XS1qn021IkyKmHBBypB9XLVYsALXQbWqxeaWp6RgbgmgPAmzVdelZY4I9sxIZ1qiivG9d1wM3yCqvH96j+A6oXG5mk0gghC/Yg9PdU+QQV1RfaytncsFG9IwpMR/M6xMmr8V4N+DRpocKrj6cSaglyd22sEJ6KeP5B2D76AQ40HOPYaLdbaZXeTFr2UhfA+0jEA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(136003)(376002)(366004)(39860400002)(54906003)(1076003)(6916009)(316002)(9686003)(7696005)(6506007)(55016002)(83380400001)(15650500001)(86362001)(8676002)(5660300002)(4326008)(52116002)(66476007)(2906002)(16526019)(6666004)(186003)(33656002)(66946007)(8936002)(66556008)(478600001);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: yNNKNDxfYp9upMMl5qXqzX7Np2bdGjBj4rkHIsxF/cZarVs/7T5Smm5lmgkIYsiSCRWazUZEthtnmxN1Jyb3ICQZUX8PCbDGOHH/OYsI957z6feKTP2nvkuykbxoAKl5DmoeKkarEoQauDa0HAkewgC7H+IIhCOmtCT+UhKNsHJbWS/o+vDh1Lbch3nZVMTES71PQWmLSf20poJYjgjfq1Z2/2YmDVBiiSu0RlBi/SY+3i1WzY8fOResrsgc0f9ZvMROFgvmIYeywSBnA9p2RIZ2JkMAX2Jxg10QdsJmXhWbkzGaX+GWK9Tdx9cTkm2SgN/87RjUMr9dnuUFsLsnkini2sBB1KwncbF+C+Z/KiFlqTBcXNDLlhAYRaCVV8wRtqF9Qmu3w2FfhL0rfOtYKtdr01iU5gxTqwUaD+MIiFg0czXlDMZFONYmztZldsOHlxxUJit8+WGhCwTAE+azvjQARCTywpKRaBsDAhvYaFNqmPKCmjdfcNCj7jbvFDtyF3kjFGkpP2pRRTcpxXA8FtrzX1tox9N8Iy4GKJNfpnvSALcXuzKjL8K0tHtuxIh8Z7R/i9sRUsjpDknhnaKuGwVPRkvT5s1AdAka6iQXU6ussLIPREah7M0ZozxTcof1ufsAjSUyQmq8GHEXz/6lOes5UZF1hfOcKEKhaeAj/KI=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5677ec9-a8c7-45a9-f6ed-08d885967335
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 16:34:10.0548
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YgNOYQQxSAoDz79tBLjlvym1aYVhHh2Hp99qAp33SQpG04YAyDP+r+gnzBbNVf/B
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3125
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-10_06:2020-11-10,2020-11-10 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 mlxlogscore=718 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0
 bulkscore=0 impostorscore=0 suspectscore=1 clxscore=1015 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011100118
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 10, 2020 at 10:21:43AM -0500, Johannes Weiner wrote:
> On Mon, Nov 09, 2020 at 05:06:15PM -0800, Roman Gushchin wrote:
> > Many kernel memory accounting paths are guarded by the
> > memcg_kmem_enabled_key static key. It changes it's state during
> > the onlining of the first non-root cgroup. However is doesn't
> > happen atomically: before all call sites will become patched
> > some charges/uncharges can be skipped, resulting in an unbalanced
> > charge. The problem is mostly a theoretical issue, unlikely
> > having a noticeable impact ion the real life.
> 
> memcg_online_kmem() is called from .css_alloc rather than .css_online,
> at a time where memcg is brandnew and the css hasn't been set up and
> published yet (the refcount isn't even initialized for css_tryget()).
> 
> I don't really see how charges could race with that.

You're right. I was thinking of it in the context of a patchset causing
the root memory cgroup to be charged as any other cgroup. In that case,
the root memory cgroup can be accessed and charged as soon as we set
root_mem_cgroup, and it happens exactly in mem_cgroup_css_alloc().
As in the current state, it's indeed not a problem.

> 
> We may want to rename memcg_online_kmem() to memcg_alloc_kmem() or
> something.
> 
> > Before the rework of the slab controller we relied at setting
> > kmemcg_id after enabling the memcg_kmem_enabled_key static key.
> > Now we can use the setting of memcg->objcg to enable the slab
> > memory accounting atomically.
> 
> I suspect that code comment has been out of date since commit
> 0b8f73e104285a4badf9d768d1c39b06d77d1f97.

I'll send a patch to cleanup these obsolete comments.

Thanks!