Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbWHUCaY (ORCPT ); Sun, 20 Aug 2006 22:30:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751807AbWHUCaY (ORCPT ); Sun, 20 Aug 2006 22:30:24 -0400 Received: from smtp-relay.dca.net ([216.158.48.66]:28383 "EHLO smtp-relay.dca.net") by vger.kernel.org with ESMTP id S1751805AbWHUCaX (ORCPT ); Sun, 20 Aug 2006 22:30:23 -0400 Date: Sun, 20 Aug 2006 22:30:17 -0400 From: "Mark M. Hoffman" To: Michal Piotrowski Cc: Andrew Morton , Frodo Looijaard , Philip Edelbrock , Mark Studebaker , lm-sensors@lm-sensors.org, LKML Subject: Re: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Message-ID: <20060821023017.GA30017@jupiter.solarsys.private> References: <44E8C9AE.3060307@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44E8C9AE.3060307@gmail.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 31 Andrew, Michal: * Michal Piotrowski [2006-08-20 22:44:30 +0200]: > This patch fixes 56 sparse "ignoring return value of 'device_create_file'" warnings. It also adds error handling. > > w83627hf.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 80 insertions(+), 16 deletions(-) Thanks for doing this... but Andrew please don't apply it. The sensors project people are working on these even now, and we already have a patch for the w83627hf driver... http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017204.html Jean Delvare (hwmon maintainer) should be sending these up the chain soon. Michal: if you're interested in fixing any of the rest of them, please take a look at the patch above to see the mechanism we intend to use. It actually makes the drivers *smaller* than they were. Regards, -- Mark M. Hoffman mhoffman@lightlink.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/