Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 12:43:16 -0500
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Syed Nayyar Waris <syednwaris@gmail.com>
Cc:     Michal Simek <michal.simek@xilinx.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v12 4/4] gpio: xilinx: Utilize generic bitmap_get_value
 and _set_value
Message-ID: <20201110174316.GA12192@shinobu>
References: <20201109123411.GA19869@syed>
 <20201109134128.GA5596@shinobu>
 <CAK8P3a2FMkMc0K+hu0pnqC8wEMeapKPkZXaBm+HFYYPTes5NHA@mail.gmail.com>
 <20201109164529.GA28710@syed.domain.name>
 <20201109171140.GA14045@shinobu>
 <20201109172220.GI4077@smile.fi.intel.com>
 <20201109173107.GA14643@shinobu>
 <fe1cfe4c-e4d7-f9fb-1218-7a1d48e6f68a@xilinx.com>
 <20201110123538.GA3193@shinobu>
 <CACG_h5p84sKjDnK5xYRNjGnRzwsbjZ-76P-cC13LKx=7x=4KqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5"
Content-Disposition: inline
In-Reply-To: <CACG_h5p84sKjDnK5xYRNjGnRzwsbjZ-76P-cC13LKx=7x=4KqQ@mail.gmail.com>
Precedence: bulk


--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 10, 2020 at 10:52:42PM +0530, Syed Nayyar Waris wrote:
> On Tue, Nov 10, 2020 at 6:05 PM William Breathitt Gray
> <vilhelm.gray@gmail.com> wrote:
> >
> > On Tue, Nov 10, 2020 at 11:02:43AM +0100, Michal Simek wrote:
> > >
> > >
> > > On 09. 11. 20 18:31, William Breathitt Gray wrote:
> > > > On Mon, Nov 09, 2020 at 07:22:20PM +0200, Andy Shevchenko wrote:
> > > >> On Mon, Nov 09, 2020 at 12:11:40PM -0500, William Breathitt Gray w=
rote:
> > > >>> On Mon, Nov 09, 2020 at 10:15:29PM +0530, Syed Nayyar Waris wrote:
> > > >>>> On Mon, Nov 09, 2020 at 03:41:53PM +0100, Arnd Bergmann wrote:
> > > >>
> > > >> ...
> > > >>
> > > >>>>  static inline void bitmap_set_value(unsigned long *map,
> > > >>>> -                                    unsigned long value,
> > > >>>> +                                    unsigned long value, const =
size_t length,
> > > >>>>                                      unsigned long start, unsign=
ed long nbits)
> > > >>>>  {
> > > >>>>          const size_t index =3D BIT_WORD(start);
> > > >>>> @@ -15,6 +15,10 @@ static inline void bitmap_set_value(unsigned =
long *map,
> > > >>>>          } else {
> > > >>>>                  map[index + 0] &=3D ~BITMAP_FIRST_WORD_MASK(sta=
rt);
> > > >>>>                  map[index + 0] |=3D value << offset;
> > > >>>> +
> > > >>>> +               if (index + 1 >=3D length)
> > > >>>> +                       __builtin_unreachable();
> > > >>>> +
> > > >>>>                  map[index + 1] &=3D ~BITMAP_LAST_WORD_MASK(star=
t + nbits);
> > > >>>>                  map[index + 1] |=3D value >> space;
> > > >>>>          }
> > > >>>
> > > >>> Hi Syed,
> > > >>>
> > > >>> Let's rename 'length' to 'nbits' as Arnd suggested, and rename 'n=
bits'
> > > >>> to value_width.
> > > >>
> > > >> length here is in longs. I guess this is the point of entire patch.
> > > >
> > > > Ah yes, this should become 'const unsigned long nbits' and represen=
t the
> > > > length of the bitmap in bits and not longs.
>=20
> Hi William, Andy and All,
>=20
> Thank You for reviewing. I was looking into the review comments and I
> have a question on the above.
>=20
> Actually, in bitmap_set_value(), the intended comparison is to be made
> between 'index + 1' and 'length' (which is now renamed as 'nbits').
> That is, the comparison would look-like as follows:
> if (index + 1 >=3D nbits)
>=20
> The 'index' is getting populated with BIT_WORD(start).
> The 'index' variable in above is the actual index of the bitmap array,
> while in previous mail it is suggested to use 'nbits' which represent
> the length of the bitmap in bits and not longs.
>=20
> Isn't it comparing two different things? index of array (not the
> bit-wise-length) on left hand side and nbits (bit-wise-length) on
> right hand side?
>=20
> Have I misunderstood something? If yes, request to clarify.
>=20
> Or do I have to first divide 'nbits' by BITS_PER_LONG and then compare
> it with 'index + 1'? Something like this?
>=20
> Regards
> Syed Nayyar Waris

The array elements of the bitmap memory region are abstracted away for
the covenience of the users of the bitmap_* functions; the driver
authors are able to treat their bitmaps as just a set of contiguous bits
and not worry about where the division between array elements happen.

So to match the interface of the other bitmap_* functions, you should
take in nbits and figure out the actual array length by dividing by
BITS_PER_LONG inside bitmap_set_value(). Then you can use your
conditional check (index + 1 >=3D length) like you have been doing so far.

William Breathitt Gray

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+q0SkACgkQhvpINdm7
VJKhMRAAricUh4JzphV3n0FFvtd+6BR3bMIY06bgAWbzFhvOBj4P78ZZCZTabPS4
ba11PaSdWz4ZHIiOihh+22uiEdIKYGz0cnYE1ZmvDg62HGqkwbpIQX3ei5wR37aQ
R2LG0yCryexwxpKwPfiJ5hlSx9MBhaGOi9ptSRQM+OD0WYqyn+YDcXDhnBA6NEXa
yDpqEkoA0w5BOuBHIxb4aUeKx58bz2n2mRCTi68QtMg5e8n6sww5gAQV1Vxg56IZ
qY0BoE7JwReQI54fo/TuiIgR145pvYoTFsBO5VnTmXd/E4AN+9k4TBZMinVv3saj
2qH0Az6xs9LEhpD1acgLh8v3EjM8uFzUcRUDaKRZU4BUiXMBdB8CQpHqqWoQUiDS
8nV4jaZE34dFwHRbB13Bl67FztviugMyul8Hv1oPdbOeaY3CSuy7Up8j5kI0YcVJ
tl+Ev9Df2GPkLzV+Am9XP62GN5lZ3DnCLdpYRs+VIK3cdzgNLD4rMF3rIjHeFEHV
jWdpF/SqlX9+6rWYpxFmUXaafBUVWB3E/ExDXgATeiEeQC1jmVVVHZ43JBSrQi81
CsaQtRs0fpxuyT1HhG/y6yFMzooZAkrvCAsbiS7yCyYm1AAvsSUjybkdTsklzVUo
+s3CiEe7Wz40kn/BJHIWUy0fiwWgdKCROw8C8bzEdKEUco60EB8=
=lx3m
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--