Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Limonciello, Mario" <Mario.Limonciello@dell.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Bastien Nocera <hadess@hadess.net>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>
Subject: RE: How to enable auto-suspend by default
Thread-Topic: How to enable auto-suspend by default
Thread-Index: AQHWt1BE6l+LjsERUU+/FRV4X0h3ganBPDeAgABA9KCAAB8fAIAABiww
Date:   Tue, 10 Nov 2020 17:45:43 +0000
Message-ID: <DM6PR19MB2636460E97BD5E47957BB43AFAE90@DM6PR19MB2636.namprd19.prod.outlook.com>
References: <fe8ab4cab3740afd261fa902f14ecae002a1122d.camel@hadess.net>
 <X6p6ubTOoMPUPPXi@kroah.com>
 <DM6PR19MB2636C94B56D5FBC0BD98A1B0FAE90@DM6PR19MB2636.namprd19.prod.outlook.com>
 <X6rLUDuG0N98jz18@kroah.com>
In-Reply-To: <X6rLUDuG0N98jz18@kroah.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Enabled=True;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Owner=Mario_Limonciello@Dell.com;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_SetDate=2020-11-10T17:40:15.8416521Z;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Name=External Public;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_ActionId=a04f1a67-ceec-483f-8088-81c3fa3b9d8f;
 MSIP_Label_17cb76b2-10b8-4fe1-93d4-2202842406cd_Extended_MSFT_Method=Manual
authentication-results: linuxfoundation.org; dkim=none (message not signed)
 header.d=none;linuxfoundation.org; dmarc=none action=none
 header.from=Dell.com;
x-originating-ip: [76.251.167.31]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b3546588-64f4-4a04-cbc8-08d885a07289
x-ms-traffictypediagnostic: DM5PR19MB0027:
x-microsoft-antispam-prvs: <DM5PR19MB00273E181C26CB82F9990843FAE90@DM5PR19MB0027.namprd19.prod.outlook.com>
x-exotenant: 2khUwGVqB6N9v58KS13ncyUmMJd8q4
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QAGFki5nkubI9JfcDtDtWZVBLqJpa+r/iQJvcBIUG8bipgrR0SjHaha9ukT4s6UsPNc1Ewv8QrJoWY81ZNFmjge1HL23arVR32nkweT+7RC2X14WgyqG82cXmoOLi6eUcC51p8PNVCc0NkATbL7pszNlCfXhoCAQmZcZiuKTlhaCMDv7wAvNKu+oCQZX6m1DyQP6M8cbfWwSKW3FA7H7GRU83g8n3eFFwq2Dirgv7w5zTVLDXMw2JJvjRvsoQNrL6cNbE2x2QDX/4qm+kCUhutTL9LzePauPVXWHBX+UC4aQ1RaPrIdbJbxHE4j2Ib5l3hxXlPoGzKTj9gl1WNsoKYEfEihPMi5fv116n/EqR5G37OP38JFHh3hGf74R/4bmIm8uXe1fLf0XfqehuLz9mA==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR19MB2636.namprd19.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(26005)(15650500001)(5660300002)(66946007)(52536014)(8676002)(316002)(6506007)(66476007)(66556008)(8936002)(55016002)(54906003)(6916009)(786003)(86362001)(4326008)(66446008)(186003)(76116006)(64756008)(33656002)(478600001)(7696005)(71200400001)(9686003)(966005)(83380400001)(2906002);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: nCZZ5FDeqnjef+M9wbaeauMxiy7kIXCgLawx0+I8S7j0ZmYGPlFw7/uBokYH5Y4srjW37E82w2m6keFueEjmcei7kl5zQHq4A267uzQvwsv85tHG7Haz309bvjjcTfMx45yvLzzvD6qwrOdZaO7rCZUv0V23hdvnhtw1cewtKck2Y0t1IqiR+xWdQaqlB8WIMOO262qYEeEOyXG9EU6B2tvwJVPuF8oaQtKA4Np0w52Z9JwsUC3JlI2ZdpnIspDlRRFEcwPD+3rpgfvsgTLIhUdCXwm4DHIsjVX0mWz9Icg5AUdvOLlUxlJRaf95YC2yqjjVwDGiF8Hflv1S6iiEr7rcyZXNPXxfiWobun62pmIrR81s0zKz7lAPTZKb+NDBQpjaokkLn1lO0AHnOkUKjV4r7imM8Jht0oO0Ksf6Qfsgi1maGOEHxKRFvyFDJ4+XlaF/aIW4KvRWU6j7zyr7cfkM9gnsLQikkM0P2ML2OgijORFOM0G0NM9PbBB4Zy0fQrjzLfhetrakoayd7CZikIdoHAdE32tFJPnT3jrYEzwpD2ZuTTiatFo1YWZh3HzODDbleGJxfsPUmCNhIn9obf1cjM9blhqYE6FrYXIbL3+J9VyRMTJwkNreGg2uEwSc02/G28EUJ3Qo/LeenztlGw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Dell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR19MB2636.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3546588-64f4-4a04-cbc8-08d885a07289
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2020 17:45:43.4910
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 945c199a-83a2-4e80-9f8c-5a91be5752dd
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nIFSHplSQ9aPMjjJ6mkCzDoRE+dGb5H2A0Eq7bXv3ywSwiQmAEMiDS1vlFNkaJ7NRcsWPkihk7cT6VDcgQ6pYsVW1AYldzLlDlSXjNE4vbo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR19MB0027
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-10_07:2020-11-10,2020-11-10 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 adultscore=0 spamscore=0 impostorscore=0 mlxscore=0 bulkscore=0
 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=759
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011100124
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 spamscore=0 mlxscore=0 suspectscore=0 mlxlogscore=871 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2011100124
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > I guess what Bastien is getting at is for newer devices supported by cl=
ass
> > drivers rather than having to store an allowlist in udev rules, can we =
set
> > the allowlist in the kernel instead.  Then distributions that either do=
n't
> > use systemd or don't regularly update udev rules from systemd can take
> > advantage of better defaults on modern hardware.
>=20
> That's what the "hardware ids" database is supposed to be handling.
> It's easier to manage this in userspace than in the kernel.
>=20
> I just love systems where people feel it is safer to update the kernel
> than it is to update a hardware database file :)
>=20
> > The one item that stood out to me in that rules file was 8086:a0ed.
> > It's listed as "Volteer XHCI", but that same device ID is actually pres=
ent
> > in an XPS 9310 in front of me as well and used by the xhci-pci kernel
> module.
>=20
> That's an Intel PCI device id.  If someone else is abusing that number,
> I'm sure Intel would want to know about it and would be glad to go after
> them.

Sorry I wasn't intending to insinuate an abuse of the number, but rather th=
at
the PCI device in the "Volteer" product and that in XPS 9310 appear are the
same so they are possibly using the same hardware for this device.

>=20
> But note, PCI devices can be behind lots of different types of busses,
> so maybe the "can this device autosuspend" differs for them because of
> different implementations of where the device is, right?
>=20

Well the reason that I raise it is that without that device auto-suspended =
the
SOC on the XPS 9310 consumes too much power.

> > Given we're effectively ending up with the combination of runtime PM tu=
rned
> > on by udev rules, do we need something like this for that ID:
> >
> >
> https://github.com/torvalds/linux/commit/6a7c533d4a1854f54901a065d8c672e8=
90400
> d8a
> >
> > @Mika Westerberg should 8086:a0ed be quirked like the TCSS xHCI too?
>=20
> Submit a patch!
>=20
> thanks,
>=20
> greg k-h

If that's the appropriate conclusion, will do.