Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201023110254.26360-1-yu.c.chen@intel.com>
In-Reply-To: <20201023110254.26360-1-yu.c.chen@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 10 Nov 2020 19:43:25 +0100
Message-ID: <CAJZ5v0jxAwOHbUwpqibvjW-LbZmhOPwaPrekZ6JRcQVGKb+AjQ@mail.gmail.com>
Subject: Re: [PATCH] PM / suspend: Print the driver flags of device during
 suspend resume
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 23, 2020 at 1:02 PM Chen Yu <yu.c.chen@intel.com> wrote:
>
> Currently there are 4 driver flags to control system suspend/resume
> behavior: DPM_FLAG_NO_DIRECT_COMPLETE, DPM_FLAG_SMART_PREPARE,
> DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME. Print these flags
> during suspend resume so as to get a brief understanding of the
> expected behavior of each device, and to facilitate suspend/resume
> debugging/tuning.
>
> To enable this tracing:
> echo 'file drivers/base/power/main.c +p' >
> /sys/kernel/debug/dynamic_debug/control
>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
>  drivers/base/power/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 205a06752ca9..be6744bdfc93 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -442,9 +442,9 @@ static pm_callback_t pm_noirq_op(const struct dev_pm_ops *ops, pm_message_t stat
>
>  static void pm_dev_dbg(struct device *dev, pm_message_t state, const char *info)
>  {
> -       dev_dbg(dev, "%s%s%s\n", info, pm_verb(state.event),
> +       dev_dbg(dev, "%s%s%s driver flags: %x\n", info, pm_verb(state.event),
>                 ((state.event & PM_EVENT_SLEEP) && device_may_wakeup(dev)) ?
> -               ", may wakeup" : "");
> +               ", may wakeup" : "", dev->power.driver_flags);
>  }
>
>  static void pm_dev_err(struct device *dev, pm_message_t state, const char *info,
> --

Applied (with some edits in the subject and changelog) as 5.11 material, thanks!