Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4225932pxb; Tue, 10 Nov 2020 10:52:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEwVHgxKrIK8As9YS5kxmHYmCOlCpBsF3jSmKI/+KWVOVSidf6fi7JDF18EeLT9cpO4rqy X-Received: by 2002:a17:906:b53:: with SMTP id v19mr20837400ejg.136.1605034355185; Tue, 10 Nov 2020 10:52:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605034355; cv=none; d=google.com; s=arc-20160816; b=jsIKwCHo9dvg/xU0ghmukGj5PPI85wtO8IHzEGlPTz9v3vOuDVNbzvXcefWTck9INt wSjGuYYgGtw32BZLwZwqUKHMvLCJCLLOYrMMv8EdAIYI9uQjQOBdhpGLNKwXD6Ur0PUm Wd+Nf+56Fm10pDEKvE/O/k6fr7l85Xr6Hgi8EDFckc62pyPipJTNG0GKeg1MGLuKWAGj lYYUCYYjYNWOJXR6I+XiEtwTuAA9FkGt6majezah2fs4CHLTTX8gJBX02ZIOfROcgPuc 1iOLNufki4dQEAnXrKHlNJZpPWxag8KTwrWTnJaeuNt8Vkv6KFgx0rqsbXL4owjuKc9x 5NvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ao4gO8dckdnbUrVLtqZDO6K8/CHWVv04osrwbe3s3CE=; b=UgFdXcEDvUpBy48fsg8AGe4pEL1dYVq8QmOl/pIYtD5FRO1VLT45/xevFQ9NSCSbj8 L5dSaxYSQR7wRISbQX+OKXP7KCdSYtSeP6ughE3uNqB1t2CJ4iOULIZiZVx+ns+xJSOI CaNPKBrdk/byxIEUwnG/jlD15aEpeE0gMwcOhGfIRAhBmuKNFHSAnrjjyi86DY9yOE1U QvkxNgDAFTdrDUwyTPFTk+k3l/z4V4Sal822zPS3zaGOI+N95pvJwuecwHVGaoYRUqO7 1h8msNVoFx1N4Ku/HQRI4RBx0BOFwchQTm7Dq8Ug5KpxF1L9S5mCwSOK2RYEqpJRbGse l5nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=aD1YSSjm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r1si10318723ejh.137.2020.11.10.10.52.11; Tue, 10 Nov 2020 10:52:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=aD1YSSjm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731534AbgKJSup (ORCPT + 99 others); Tue, 10 Nov 2020 13:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731417AbgKJSul (ORCPT ); Tue, 10 Nov 2020 13:50:41 -0500 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 853E5C0613D1 for ; Tue, 10 Nov 2020 10:50:39 -0800 (PST) Received: by mail-qv1-xf42.google.com with SMTP id 13so6370130qvr.5 for ; Tue, 10 Nov 2020 10:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ao4gO8dckdnbUrVLtqZDO6K8/CHWVv04osrwbe3s3CE=; b=aD1YSSjm5h1E5fKJUFCbr7un4ITDFwPpH6MF9varMrqIuVbGJBuFVykbxLg6VBTlR2 tUkpEBkPpR8DPcUIo0qFS6gFiGku7QOoKoQBtjKBKDNpokJOdt4IStbsoWjphGGuEIe3 rsI4GBvWMkch7slymkedYAaZbD+xCPLbfIZ6GnBCRmIMgFA/3XwHS4WrRB+h21kNDxEv yOCKKNCwlspZuRBiQvvK9EdTbTaHZ+3cJcK3xZLEcFIWMSEjzeJQGDQ+wlOIpFQISCyd rss3dJMftolMW5jlmv73BOiORadddv7rPLT2D1Ncc6b1S+mG7UF7n7uZBlthn8zRh769 2Paw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ao4gO8dckdnbUrVLtqZDO6K8/CHWVv04osrwbe3s3CE=; b=tS3hG1gyqTFLJcU/Y6snoBO86Ok6ndU5vTasOI7kK8f56DQTb+BCvfhJJkLBFB7ffr vTuwaYxEzXhqaMNVQhw3O60ipPsuD1IfWBNAI4L8GZHC9JU4baldBGCdOWo1eJp3/4P3 bM8r7ait0bSvjEuKh6b2+Zqrj/tpitzdiiP/gxjc4FSwQ2xhdyPBt+1yBKo42cCAil8R fiXowIeCo+nDe7kF0si2Orcqr8LSPObgx+UAKlO3nuhhiKA2RGZ5aWyuNlVthn5XhTAz 3XngjXvwLxV4ZJLhrOaPPdBOcAkC0WMSy2fgcryKWklFJGSly0CqWfM3HFZRk/MsKB0u EmRw== X-Gm-Message-State: AOAM532Bbw+BqGpAEgUQThhNRHMiGTHeSMUq/zdc+oo3xCOXnBqzTLt9 hBajWb1oJLc5UnceHLtzwppZSA== X-Received: by 2002:ad4:4943:: with SMTP id o3mr20168428qvy.9.1605034238663; Tue, 10 Nov 2020 10:50:38 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:64f7]) by smtp.gmail.com with ESMTPSA id c76sm9398105qkb.20.2020.11.10.10.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 10:50:37 -0800 (PST) Date: Tue, 10 Nov 2020 13:48:50 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Shakeel Butt , Michal Hocko , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: memcg: fix obsolete code comments Message-ID: <20201110184850.GA850433@cmpxchg.org> References: <20201110184615.311974-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110184615.311974-1-guro@fb.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 10:46:15AM -0800, Roman Gushchin wrote: > This patch fixes/removes some obsolete comments in the code related > to the kernel memory accounting: > - kmem_cache->memcg_params.memcg_caches has been removed > by commit 9855609bde03 ("mm: memcg/slab: use a single set of > kmem_caches for all accounted allocations") > - memcg->kmemcg_id is not used as a gate for kmem accounting since > commit 0b8f73e10428 ("mm: memcontrol: clean up alloc, online, > offline, free functions") > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner Thanks Roman