Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201110181250.264394-1-shy828301@gmail.com> <20201110181250.264394-4-shy828301@gmail.com>
 <20201110181636.GJ17076@casper.infradead.org>
In-Reply-To: <20201110181636.GJ17076@casper.infradead.org>
From:   Yang Shi <shy828301@gmail.com>
Date:   Tue, 10 Nov 2020 10:58:29 -0800
Message-ID: <CAHbLzko+++aGr08js=J6_jmiHSM4zv1XFzGuqpjRdpR_f3+C1A@mail.gmail.com>
Subject: Re: [v2 PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
        Song Liu <songliubraving@fb.com>, Mel Gorman <mgorman@suse.de>,
        Jan Kara <jack@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 10, 2020 at 10:16 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Tue, Nov 10, 2020 at 10:12:48AM -0800, Yang Shi wrote:
> > @@ -2142,6 +2151,10 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
> >       int page_lru = page_is_file_lru(page);
> >       unsigned long start = address & HPAGE_PMD_MASK;
> >
> > +     if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) &&
> > +         is_shared_exec_page(vma, page))
> > +             goto out;
>
> Why include the IS_ENABLED() check?  Once the ~50 patches I have pending
> go in, shared executable THPs can exist without this option.  And can't
> we have executables on tmpfs today without this option too?

Aha, yes, thanks for reminding. I had the patches baked in my tree
before your patches were posted.

We could have executables on tmpfs w/o that config. Will remove it. Thanks.