Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4233036pxb; Tue, 10 Nov 2020 11:03:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpVTi3KJQfLo/OEezfQoyrtKx2Dy1f9t2bSHqbdksfwspdyLb9QEx5XdhCG0vfzWC5hCkd X-Received: by 2002:aa7:c50e:: with SMTP id o14mr22674129edq.80.1605034995485; Tue, 10 Nov 2020 11:03:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605034995; cv=none; d=google.com; s=arc-20160816; b=G5cfPsqqnMQiiMAuiqAvpY5gvd+lNI2WkyfaVzXcMFKIM1tSIcKsYkrFBeasCE9fIe fIP/AX1vhriqiXGAzkJpTrdoUr69ewIkcIx4m64QzQphRX83fymkpQKGfxAJr2NsonRa OinW9Zc3K5neTD+DUSc5ZCcXmGb6QwsVDePFSNuokc74o6cr5YUkw8cNOfBTKReIqEbe SEHHJJ8pptgJU+9vkLfdq5+Cdq5brvjlb5vKjyTaH4E78XrVCIOp21DahzIFl3Q6BagV K1F1Cw3CtxIpgVZxZ1ngaYt+JW+0PU+P3LrkDG9yj5sZCEH9wtAMOQ9R0CNjo+ozBDcQ +1rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=zKnP0UjT9/41FW96welsKE4nmHYtePDjICGtIuKNYDE=; b=Cmkpziq05G225kZ37CgsdGQIIPooP9F5Xwx0g2MCURteWVtLCyJjBoNvBor/MBQN3I q2LSENdPJcji7LaH1TioAzOX54ik61yFsXVOPRb8Dv6GEBiqD+5hq986hgMHQrEg6cxQ NYvJb030gBps602caG5MdYulSlA7QO914AYeWaFBKymHtHuvYXuC5konFincR32fxgpm 3uD73DxBK35OqcZVORXmgjN5GtjInkUqyTLAppmWmBP9QxghyJpcb9RV9b30o0BN3voB Hx9GWtTOIS70gZPDPDvckabhBFMAvwN39QECSbarSEpSsESRC7MfLwcaaGOQwFYVyrHR cXqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YutSGkcI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e13si11426262edj.548.2020.11.10.11.02.50; Tue, 10 Nov 2020 11:03:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=YutSGkcI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731417AbgKJTBR (ORCPT + 99 others); Tue, 10 Nov 2020 14:01:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730775AbgKJTBQ (ORCPT ); Tue, 10 Nov 2020 14:01:16 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C82C0613D1 for ; Tue, 10 Nov 2020 11:01:15 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id e27so19117868lfn.7 for ; Tue, 10 Nov 2020 11:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKnP0UjT9/41FW96welsKE4nmHYtePDjICGtIuKNYDE=; b=YutSGkcINLiH87RXw6H6GyKh691g0QzbgNl7CF4HK08iAClCp9ea/n89O0RSe2aNmb Ur9I2aaz3qjCQ1CVxCZrwzro/3uPHPE6hLU5TegLPUTE8LAEjX+1RA2mh0uC0hjT0Kdk fTH/PUwuj5ZMwRxfryXySmYoQNPa9wkVclmN7xSW8RrTkWvPkVVkKpuA9LINs0tIxKSt JKlFHkT2+IU19ecYwZqiIwautQRIPzJSwOuf75WjGxwS1MyrSoJ6T0PZBnWP5SVdxgNF IIJBz79fOk2GKvBzFDx4hlJhjrYkiGpocwnWXRpSEUgRPfbXcDJU/dNbK2CVKDm296Wa SjlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKnP0UjT9/41FW96welsKE4nmHYtePDjICGtIuKNYDE=; b=BoNwHt5yKEGiYDEt8OeyJVnv36hCV5Sxtcmd/iAt/H4DzcoJqb842zx0PYPhefNNAF Jd+lZuz6hfznC571Rhf/2s+CTD1NT1dOfe+mVIfx2H3xoCWyXB74pCToUEwh2ijfvg2F 7FQivCD/LxJwuXSHgtFk1CpZnd9INSaXIvsCQ9/MseyeN1cbcjLl9ErBrRtNmyXY9CnT g7YNwzsOeH1Rw10y/3SAbKVveHyNRjsAglyEe5pRtDRCuomxCAnEGBYRI93y1nKk+EJQ Qm4bYeEJUJYm/uO45+HH+GDf3Og8M4JmRsqt6+XyfOAV3ZKgWfvyaY4P8IlXC3c+jGoP srxQ== X-Gm-Message-State: AOAM533a23o6YEw/vBytCFmxA/o8jWn5gBEShL1QxKZmpCj5WUj6gtAa UJpz2FTaByE+OP4BJSVV1pQrmg6OzcsqmeLs6Cs7kA== X-Received: by 2002:a19:85c2:: with SMTP id h185mr8571397lfd.494.1605034874125; Tue, 10 Nov 2020 11:01:14 -0800 (PST) MIME-Version: 1.0 References: <20201110184615.311974-1-guro@fb.com> In-Reply-To: <20201110184615.311974-1-guro@fb.com> From: Shakeel Butt Date: Tue, 10 Nov 2020 11:01:02 -0800 Message-ID: Subject: Re: [PATCH] mm: memcg: fix obsolete code comments To: Roman Gushchin Cc: Andrew Morton , Linux MM , Johannes Weiner , Michal Hocko , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 10:46 AM Roman Gushchin wrote: > > This patch fixes/removes some obsolete comments in the code related > to the kernel memory accounting: > - kmem_cache->memcg_params.memcg_caches has been removed > by commit 9855609bde03 ("mm: memcg/slab: use a single set of > kmem_caches for all accounted allocations") > - memcg->kmemcg_id is not used as a gate for kmem accounting since > commit 0b8f73e10428 ("mm: memcontrol: clean up alloc, online, > offline, free functions") > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt