Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 20:16:12 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        Arnd Bergmann <arnd@arndb.de>,
        Thierry Reding <treding@nvidia.com>,
        Timo Alho <talho@nvidia.com>, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] firmware: tegra: fix strncpy()/strncat() confusion
Message-ID: <20201110191612.GA2303484@ulmo>
References: <20201026164937.3722420-1-arnd@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="/04w6evG8XlLl3ft"
Content-Disposition: inline
In-Reply-To: <20201026164937.3722420-1-arnd@kernel.org>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--/04w6evG8XlLl3ft
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 26, 2020 at 05:49:21PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The way that bpmp_populate_debugfs_inband() uses strncpy()
> and strncat() makes no sense since the size argument for
> the first is insufficient to contain the trailing '/'
> and the second passes the length of the input rather than
> the output, which triggers a warning:
>=20
> In function 'strncat',
>     inlined from 'bpmp_populate_debugfs_inband' at ../drivers/firmware/te=
gra/bpmp-debugfs.c:422:4:
> include/linux/string.h:289:30: warning: '__builtin_strncat' specified bou=
nd depends on the length of the source argument [-Wstringop-overflow=3D]
>   289 | #define __underlying_strncat __builtin_strncat
>       |                              ^
> include/linux/string.h:367:10: note: in expansion of macro '__underlying_=
strncat'
>   367 |   return __underlying_strncat(p, q, count);
>       |          ^~~~~~~~~~~~~~~~~~~~
> drivers/firmware/tegra/bpmp-debugfs.c: In function 'bpmp_populate_debugfs=
_inband':
> include/linux/string.h:288:29: note: length computed here
>   288 | #define __underlying_strlen __builtin_strlen
>       |                             ^
> include/linux/string.h:321:10: note: in expansion of macro '__underlying_=
strlen'
>   321 |   return __underlying_strlen(p);
>=20
> Simplify this to use an snprintf() instead.
>=20
> Fixes: 5e37b9c137ee ("firmware: tegra: Add support for in-band debug")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: Use the correct arguments for snprintf(), as pointed out by Arvind Sa=
nkar
> ---
>  drivers/firmware/tegra/bpmp-debugfs.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Applied, thanks.

Thierry

--/04w6evG8XlLl3ft
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+q5voACgkQ3SOs138+
s6F/kA/9G/n73HeUjhQYS1PxKSzJnvsWnUjYOtQqX+Dq7ajfxmT+fBwqKJisBcJD
1A+VM8ciXWwu6CPqumquS/4CHB9gv4jthTkoL+GLhAxjiesRPpqzCMkkQPaRr9Sf
BAeCMmrtWet0aWSlikg7ncoHpN1f99gNsEcclrL1eUS0kak5Mmp1PPOZP6xdbRAD
caLBMF7M7azgiz8/Foacg2uXMyQSBKDexhLfcB1Ff4yAV8iLVQ2t7lyi7Rw4hpSE
9d3Cr6lx3Z7lwj76WcB5lh1PbZWLaERPcGuYGzhiP50FJVeBicl9vX5AEk4QFhi4
1xL0kcVmjcMOlZODeyPihuHc5qZwkMx6LnRKtSqiRqAj2m9lOaG5vWD2SfAqxoDi
W7HNbmVnwR8ch5mnUHjhbPYBnpH016NFZyJ9Bp5JndB8K3xevpRnK1czrTa+gVGH
dQIzMe9o7mUaGn95dhWpXARDRb+G9Myd2w9PIxL6oOFO3G7j1237oa8iYwMPsPIh
3wIOERxmc0QRD5SH8vKqXPOr9BMXONWf2LyYgb+lcEFAJEc2BMxXMcZ4tfVwEBNx
0PH0C2scwHTgGX6WXsyiDj+30Hj5SOe1XrrkupG3iaNVK4hRX3v/5VDh9wHnpBi3
9DDzDhi/vfIXQX9+7ouM8w6oVN+VTPP/uYNuX8KkyaU9f7hWQ+A=
=KrgJ
-----END PGP SIGNATURE-----

--/04w6evG8XlLl3ft--