Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4254218pxb; Tue, 10 Nov 2020 11:34:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwoB9LRNi0owqGXkkFhgRjorDDTNqiFGyd4kZHJOcbiDiZ61IYDtvPUlUb7rBwgh/gUd9yn X-Received: by 2002:a50:cc86:: with SMTP id q6mr23581852edi.78.1605036886294; Tue, 10 Nov 2020 11:34:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605036886; cv=none; d=google.com; s=arc-20160816; b=0mmZ/EuXdFbNN7f8aoExE/rn74gi9k3LQ7jmv9kLwjVoi2sssr09YYRAL4qs/cLflm p0otOMXI9iEG/ErPo0EK7Ie4dkpbH355zIyDhMNpYSdXR4Hrct7CgGfd2g5IImPoTcav XGEsIiduyZ8w+zHjGE6ubBgKuYmKnywNxOmBPrYJLVECIXRhXeeTd1k9iNIWM7AJS27F ngjD7n68WLKu6WwxvNMev2NzSjWoqCDGKLwwWy0+KcdaqRccA67lX/TYMOZ0pV5kDgYK GDzviK4gWYmovgL1MB4vIcs/b0TAi+IAb17XuCVz0XKLcfihxlWsDsPd7NIUVrbUDdcu K0eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+6GOQgcp8D4RGZTBstUnyoFcHjwgqFb+Hk6EZdqVWmc=; b=X3PfS3hFfd7coMQYLHmpCKtv5Vj8QWcIdEwCOgPsgIcEIHd+33NfNd6UK9KzDfqDLd XAuDSw2H8VeY0IjwyH9HHc8tp0A4LBSbfnQOjfDbMLInm2Zy4CKPDSYJr0ZirZYKn6EY H4u+eha0ymXVW1Xlr305W07fAk+XO+PAKdTWrN7B2Lhq76oLcRT5t6CeczHb9FNhE1lV BQQ2B0KoMnFf+NeCWpXCTr5bIOLtOJoLpH9EgEiunRXnH3NLgBPAVcSi/KSpPvJwZLHw +jXB+dw0Ori7eO74dyGuaGxmmK3XzIsXsb7vmZqYHWZMz4aUIafxXH46p1a2ebZz6mTc xnmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nL1qy7p8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oi23si9842808ejb.676.2020.11.10.11.34.21; Tue, 10 Nov 2020 11:34:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nL1qy7p8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731989AbgKJTcU (ORCPT + 99 others); Tue, 10 Nov 2020 14:32:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732004AbgKJTcS (ORCPT ); Tue, 10 Nov 2020 14:32:18 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6458BC0613D3 for ; Tue, 10 Nov 2020 11:32:18 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id f16so13685198otl.11 for ; Tue, 10 Nov 2020 11:32:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+6GOQgcp8D4RGZTBstUnyoFcHjwgqFb+Hk6EZdqVWmc=; b=nL1qy7p8kfWkS19TAqkpvrp3M3gTLjfjRYWlzV017KGib4EpPyCFzaQeeQOGUrF7xj qQ8nDAJ5UcbLNb5Bmx4zKKT01e00uYr99uVl7lVBQtn0gt3fyTvjW6vSvOYQgSQSDCL/ PrAfES26a+yws2t6NjCZOPyLIY3XBd9f6wy2YbmfgU19kkA8b+5qIQNlY4GxBZEaDL68 9WxLuJ0ESE9RBNufR/PKtRD8pprcHeNu67urxilpfGwXoqTzt6elQVo/EFpZr2s6jJBB 1KgSEqlYiRvWd/B5hhyuJ6OiSPE4Ry73cehFLnYOhu3KhamMCpETP+0SQDdoNDydIsoB 2KYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+6GOQgcp8D4RGZTBstUnyoFcHjwgqFb+Hk6EZdqVWmc=; b=tYHfoBI7l1Lqib/OA/wVV6rP5ImT12ZqBfL1bhRsP1GxHjAOh2u0dIXPq0ARGvo2Es qZS+ZQuPJYlmzNT5IncL1A1/8PGDsWCLq6eio8HtFn4XC4aTXcdk++GJukf1ftWeoK2j dTFc5MsEhqGKWZM5Z2eYp/eFLC0CXPs372u8k4Q4lDaJ/RPiS1V+ABIhkiGnMoMqlZd+ djcbgM33Uifw/xBsSLZe3cMGT2oMKikcIy1mF3tc6/ktjjh0Nw61/GysklzduQSg+X8o XrmfN/s6kTdvRQPN+4VyxmCAge4R6zXtyg9IKZUCJtrFdwRHmefi02o4OUkAgZ+RNktm LceQ== X-Gm-Message-State: AOAM531q0QBDWFFqS6IYAsXsAowJtIR3MJLsJx6uygyA50nsF2w/N5Az eUWvSzms/Ga1KeLzbTd+EdrZvuT/syKU1Z8oAYXoTw== X-Received: by 2002:a9d:323:: with SMTP id 32mr14718568otv.352.1605036737761; Tue, 10 Nov 2020 11:32:17 -0800 (PST) MIME-Version: 1.0 References: <20201110190054.20517-1-john.stultz@linaro.org> <19b7b301-3460-7ece-21d3-59cd7490c8ed@codeaurora.org> In-Reply-To: <19b7b301-3460-7ece-21d3-59cd7490c8ed@codeaurora.org> From: John Stultz Date: Tue, 10 Nov 2020 11:32:06 -0800 Message-ID: Subject: Re: [PATCH] pinctrl: qcom: Fix msm9853 Kconfig entry to depend on, not select PINCTRL_MSM To: Jeffrey Hugo Cc: lkml , Andy Gross , Prasad Sodagudi , Vladimir Lypak , Bjorn Andersson , Linus Walleij , linux-arm-msm , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:29 AM Jeffrey Hugo wrote: > > On 11/10/2020 12:00 PM, John Stultz wrote: > > One fixup following my patch commit be117ca32261 ("pinctrl: > > qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then > > a selected config") being queued in LinusW's tree, as a new > > config entry was added for the msm9853 that also needs the > > change. > > > > Applies to LinusW's pinctrl devel tree. > > > > Cc: Andy Gross > > Cc: Prasad Sodagudi > > Cc: Vladimir Lypak > > Cc: Bjorn Andersson > > Cc: Linus Walleij > > Cc: linux-arm-msm@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Signed-off-by: John Stultz > > --- > > drivers/pinctrl/qcom/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > > index 8bdf878fe970c..cf56e029cd9c7 100644 > > --- a/drivers/pinctrl/qcom/Kconfig > > +++ b/drivers/pinctrl/qcom/Kconfig > > @@ -115,7 +115,7 @@ config PINCTRL_MSM8916 > > config PINCTRL_MSM8953 > > tristate "Qualcomm 8953 pin controller driver" > > depends on GPIOLIB && OF > > - select PINCTRL_MSM > > + depends on PINCTRL_MSM > > help > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > > Qualcomm TLMM block found on the Qualcomm MSM8953 platform. > > > > Subject should indicate msm8953, no? > Sorry, I'm confused. :) The subject is "pinctrl: qcom: Fix msm9853 Kconfig..." is there something more specific you are suggesting? thanks -john