Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 10 Nov 2020 15:33:28 -0500
From:   Joel Fernandes <joel@joelfernandes.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     "Paul E. McKenney" <paulmck@kernel.org>, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org,
        jiangshanlai@gmail.com, akpm@linux-foundation.org,
        mathieu.desnoyers@efficios.com, josh@joshtriplett.org,
        tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com,
        edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com
Subject: Re: [PATCH tip/core/rcu 2/4] docs: Update RCU's hotplug requirements
 with a bit about design
Message-ID: <20201110203328.GA694269@google.com>
References: <20201105230444.GA18574@paulmck-ThinkPad-P72>
 <20201105230510.18660-2-paulmck@kernel.org>
 <20201109122317.GM2594@hirez.programming.kicks-ass.net>
 <20201109162452.GK3249@paulmck-ThinkPad-P72>
 <20201109171433.GL2611@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201109171433.GL2611@hirez.programming.kicks-ass.net>
Precedence: bulk

On Mon, Nov 09, 2020 at 06:14:33PM +0100, Peter Zijlstra wrote:
> On Mon, Nov 09, 2020 at 08:24:52AM -0800, Paul E. McKenney wrote:
> > On Mon, Nov 09, 2020 at 01:23:17PM +0100, Peter Zijlstra wrote:
> > > On Thu, Nov 05, 2020 at 03:05:08PM -0800, paulmck@kernel.org wrote:
> > > > From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
> > > > 
> > > > The rcu_barrier() section of the "Hotplug CPU" section discusses
> > > > deadlocks, however the description of deadlocks other than those involving
> > > > rcu_barrier() is rather incomplete.
> > > > 
> > > > This commit therefore continues the section by describing how RCU's
> > > > design handles CPU hotplug in a deadlock-free way.
> > > > 
> > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > > > ---
> > > >  .../RCU/Design/Requirements/Requirements.rst       | 49 +++++++++++++++++-----
> > > >  1 file changed, 39 insertions(+), 10 deletions(-)
> > > > 
> > > > diff --git a/Documentation/RCU/Design/Requirements/Requirements.rst b/Documentation/RCU/Design/Requirements/Requirements.rst
> > > > index 1ae79a1..98557fe 100644
> > > > --- a/Documentation/RCU/Design/Requirements/Requirements.rst
> > > > +++ b/Documentation/RCU/Design/Requirements/Requirements.rst
> > > > @@ -1929,16 +1929,45 @@ The Linux-kernel CPU-hotplug implementation has notifiers that are used
> > > >  to allow the various kernel subsystems (including RCU) to respond
> > > >  appropriately to a given CPU-hotplug operation. Most RCU operations may
> > > >  be invoked from CPU-hotplug notifiers, including even synchronous
> > > > -grace-period operations such as ``synchronize_rcu()`` and
> > > > -``synchronize_rcu_expedited()``.
> > > 
> > > I was under the impression that this rst crap now recognises func() and
> > > you no longer need to make the text unreadable with "``".
> > 
> > It was there to start with, but good point.  How about the commit
> > below?
> 
> Much appreciated, thanks!

Thanks for making the change, I built it and it looks good in my web browser
;-).

BTW, these APIs are obsolete due to consolidation. Paul could you remove them
from the document?:
 synchronize_rcu_bh(), synchronize_rcu_bh_expedited(), call_rcu_bh(),
 rcu_barrier_bh().

thanks!

-Joel