Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-4-lee.jones@linaro.org>
In-Reply-To: <20201109211855.3340030-4-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 10 Nov 2020 17:06:46 -0500
Message-ID: <CADnq5_PC1=sxZP2wT-jfeBwObHCRBHOdW4ceEt-2=8PaA3aYzQ@mail.gmail.com>
Subject: Re: [PATCH 03/20] drm/radeon/radeon_fence: Demote some non-conformant
 kernel-doc headers and fix another
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "moderated list:DMA BUFFER SHARING FRAMEWORK" 
        <linaro-mm-sig@lists.linaro.org>,
        Jerome Glisse <glisse@freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        linux-media <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 9, 2020 at 4:19 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/radeon/radeon_fence.c:168: warning: Function parameter o=
r member 'wait' not described in 'radeon_fence_check_signaled'
>  drivers/gpu/drm/radeon/radeon_fence.c:168: warning: Function parameter o=
r member 'mode' not described in 'radeon_fence_check_signaled'
>  drivers/gpu/drm/radeon/radeon_fence.c:168: warning: Function parameter o=
r member 'flags' not described in 'radeon_fence_check_signaled'
>  drivers/gpu/drm/radeon/radeon_fence.c:168: warning: Function parameter o=
r member 'key' not described in 'radeon_fence_check_signaled'
>  drivers/gpu/drm/radeon/radeon_fence.c:393: warning: Function parameter o=
r member 'f' not described in 'radeon_fence_enable_signaling'
>  drivers/gpu/drm/radeon/radeon_fence.c:393: warning: Excess function para=
meter 'fence' description in 'radeon_fence_enable_signaling'
>  drivers/gpu/drm/radeon/radeon_fence.c:1010: warning: Function parameter =
or member 'm' not described in 'radeon_debugfs_gpu_reset'
>  drivers/gpu/drm/radeon/radeon_fence.c:1010: warning: Function parameter =
or member 'data' not described in 'radeon_debugfs_gpu_reset'
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Jerome Glisse <glisse@freedesktop.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks.

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_fence.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c b/drivers/gpu/drm/rade=
on/radeon_fence.c
> index 8735bf2bb8b5c..9ee6e599ef83b 100644
> --- a/drivers/gpu/drm/radeon/radeon_fence.c
> +++ b/drivers/gpu/drm/radeon/radeon_fence.c
> @@ -157,7 +157,7 @@ int radeon_fence_emit(struct radeon_device *rdev,
>         return 0;
>  }
>
> -/**
> +/*
>   * radeon_fence_check_signaled - callback from fence_queue
>   *
>   * this function is called with fence_queue lock held, which is also use=
d
> @@ -383,7 +383,7 @@ static bool radeon_fence_is_signaled(struct dma_fence=
 *f)
>
>  /**
>   * radeon_fence_enable_signaling - enable signalling on fence
> - * @fence: fence
> + * @f: fence
>   *
>   * This function is called with fence_queue lock held, and adds a callba=
ck
>   * to fence_queue that checks if this fence is signaled, and if so it
> @@ -1001,7 +1001,7 @@ static int radeon_debugfs_fence_info(struct seq_fil=
e *m, void *data)
>         return 0;
>  }
>
> -/**
> +/*
>   * radeon_debugfs_gpu_reset - manually trigger a gpu reset
>   *
>   * Manually trigger a gpu reset at the next fence wait.
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel