Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4345988pxb; Tue, 10 Nov 2020 14:11:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLUXjEJR0Y35mEXgYoWjiZCkf+daVbRcs9X7VC2z++/UQy7XvAgKTUi1CoJSmUFiR49EWT X-Received: by 2002:a50:d757:: with SMTP id i23mr1622130edj.358.1605046269430; Tue, 10 Nov 2020 14:11:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605046269; cv=none; d=google.com; s=arc-20160816; b=unUR8GQSl5AEEWED8ElaBAI8BMy2/65jiehHcbd9CPgDLTB6/+kaC2a12bh8x2CGZz BjQFOSfjlNSc+gBKLsegtuVcMklKaMfZApCvYl1PIO9jyeNngoT8UQzMdJqih18sJoxu sJx7PI0gcQflomjpbUP3bI64Qj/aW7aLlD1raVkuiXHWBnCqxxEapQINC4hjjYoxq1kH QLcSXT1vsvZoYlGe5OvFUUdLzu3QRw1qCIYEvKhvoKV8CR63XdDmimlH25YabeFyvWiW TZfxXlcA+pDyZowjTt6Lt9osNd7nbcjmpvEG9a4Vkc9oESD8sfYlbDkdOyEWKaqhpSJH PnZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=Bh/X4g7eg1CB8q7LMWLH94dNX8ID4OwoQyO4pPareSM=; b=mCazn+s2MHq9Xx4NwBAGYY7j3ODSGn3qML19fb/mb5wr2TJBUgPlBbe0hWe0ZiKIDv t5/MSpYXzluMc4MBvjFHmf0/Dqe+9D9V0USzBvPJHT8hHSTkrsflhdw8k1FSIAZt97ei +BV0NYoI4lgKLvkwBwMsg3g30gIkINAhLswOPotE4DWUc8fhkuaAABHIKoLHgEvs8gP2 mq+6fgS6PgJWh2Dp/EvdCa6Q0rOWm+UE9fY1lgERxiRGPS0VtwmCfmbverp6jc7yeGxb 2pMDQe8R+VdKsys6z1e9crczgoNYw2iMR1CVRC6YzisHTUhgM6zq/wJAu0jiQBFjuljf 0RuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=gcqk0kv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay12si9746833ejb.431.2020.11.10.14.10.44; Tue, 10 Nov 2020 14:11:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=gcqk0kv9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732144AbgKJWIJ (ORCPT + 99 others); Tue, 10 Nov 2020 17:08:09 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:7132 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726688AbgKJWIH (ORCPT ); Tue, 10 Nov 2020 17:08:07 -0500 Received: from pps.filterd (m0109332.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AAM4krg009091 for ; Tue, 10 Nov 2020 14:08:05 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=Bh/X4g7eg1CB8q7LMWLH94dNX8ID4OwoQyO4pPareSM=; b=gcqk0kv9Wccw67j7LH/XGsspTzQNFIxUBpeXpkBYEp8xpF4cTttc70uNy2Vx1P1LoebP 2umyQU2chGmBhsI/BhvvjJffbAtJXrQXFyvpAJY5fYdmu9zYQo+JGFksBg4J3O2JqliC 7zL0DvIcEl2zaXoYUQI7imAwZ7aW5pyFeTw= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 34pcmjdajw-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 10 Nov 2020 14:08:05 -0800 Received: from intmgw001.41.prn1.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 10 Nov 2020 14:08:05 -0800 Received: by devvm1755.vll0.facebook.com (Postfix, from userid 111017) id 2DA9C239AED2; Tue, 10 Nov 2020 14:08:01 -0800 (PST) From: Roman Gushchin To: Andrew Morton , CC: Shakeel Butt , Johannes Weiner , Michal Hocko , , David Rientjes , , Roman Gushchin Subject: [PATCH v1 0/3] mm: memcg: deprecate cgroup v1 non-hierarchical mode Date: Tue, 10 Nov 2020 14:07:57 -0800 Message-ID: <20201110220800.929549-1-guro@fb.com> X-Mailer: git-send-email 2.24.1 X-FB-Internal: Safe Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-10_08:2020-11-10,2020-11-10 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 clxscore=1015 phishscore=0 mlxlogscore=699 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011100150 X-FB-Internal: deliver Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The non-hierarchical cgroup v1 mode is a legacy of early days of the memory controller and doesn't bring any value today. However, it complicates the code and creates many edge cases all over the memory controller code. It's a good time to deprecate it completely. This patchset removes the internal logic, adjusts the user interface and updates the documentation. The alt patch removes some bits of the cgroup core code, which become obsolete. From Michal Hocko: All that we know today is that we have a warning in place to complain loudly when somebody relies on use_hierarchy=3D0 with a deeper hierarchy. For all those years we have seen _zero_ reports that would describe a sensible usecase. Moreover we (SUSE) have backported this warning into old distribution kernels (since 3.0 based kernels) to extend the coverage and didn't hear even for users who adopt new kernels only very slowly. The only report we have seen so far was a LTP test suite which doesn't really reflect any real life usecase. v1: - added a note from Michal - added acks and reviews rfc: - https://lwn.net/Articles/835983/ Roman Gushchin (3): mm: memcg: deprecate the non-hierarchical mode docs: cgroup-v1: reflect the deprecation of the non-hierarchical mode cgroup: remove obsoleted broken_hierarchy and warned_broken_hierarchy .../admin-guide/cgroup-v1/memcg_test.rst | 8 +- .../admin-guide/cgroup-v1/memory.rst | 40 +++------ include/linux/cgroup-defs.h | 15 ---- include/linux/memcontrol.h | 7 -- kernel/cgroup/cgroup.c | 12 --- mm/memcontrol.c | 90 +++---------------- 6 files changed, 29 insertions(+), 143 deletions(-) --=20 2.26.2