Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] selftests/cgroup: Fix build on older distros
To:     Sachin Sant <sachinp@linux.vnet.ibm.com>,
        Michael Ellerman <michael@ellerman.id.au>,
        linux-kselftest@vger.kernel.org
Cc:     christian@brauner.io, linux-kernel@vger.kernel.org,
        keescook@chromium.org, Shuah Khan <skhan@linuxfoundation.org>
References: <160464840151.97255.15344214064240834294.sendpatchset@MacBook-Pro.local>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <50cb30c4-8e8d-7ba0-d429-3f1da4ad1f0b@linuxfoundation.org>
Date:   Tue, 10 Nov 2020 15:15:15 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <160464840151.97255.15344214064240834294.sendpatchset@MacBook-Pro.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/6/20 12:40 AM, Sachin Sant wrote:
> On older distros struct clone_args does not have a cgroup member,
> leading to build errors:
> 
>   cgroup_util.c: In function 'clone_into_cgroup':
>   cgroup_util.c:343:4: error: 'struct clone_args' has no member named 'cgroup'
>   cgroup_util.c:346:33: error: invalid application of 'sizeof' to incomplete
>    type 'struct clone_args'
> 
> But the selftests already have a locally defined version of the
> structure which is up to date, called __clone_args.
> 
> So use __clone_args which fixes the error.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Sachin Sant <sachinp@linux.vnet.ibm.com>>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> 
> V2: Replace all instances of clone_args by __clone_args
> ---
> 
> diff --git a/a/tools/testing/selftests/cgroup/cgroup_util.c b/b/tools/testing/selftests/cgroup/cgroup_util.c
> index 05853b0..0270146 100644
> --- a/a/tools/testing/selftests/cgroup/cgroup_util.c
> +++ b/b/tools/testing/selftests/cgroup/cgroup_util.c
> @@ -337,13 +337,13 @@ pid_t clone_into_cgroup(int cgroup_fd)
>   #ifdef CLONE_ARGS_SIZE_VER2
>   	pid_t pid;
>   
> -	struct clone_args args = {
> +	struct __clone_args args = {
>   		.flags = CLONE_INTO_CGROUP,
>   		.exit_signal = SIGCHLD,
>   		.cgroup = cgroup_fd,
>   	};
>   
> -	pid = sys_clone3(&args, sizeof(struct clone_args));
> +	pid = sys_clone3(&args, sizeof(struct __clone_args));
>   	/*
>   	 * Verify that this is a genuine test failure:
>   	 * ENOSYS -> clone3() not available
> 

Not sure how you generated the patch. I had to use git am -p2

Applied to linux-kselftest next - please make sure to generate from
top level.

thanks,
-- Shuah