Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4350676pxb; Tue, 10 Nov 2020 14:18:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzm9GS91UbREF81IsB6j0oiR0PelPyEeVWCdS64Ix9RF+gPeYyDopABTbJInDv7Ntpqoqxi X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr1672668edp.361.1605046735530; Tue, 10 Nov 2020 14:18:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605046735; cv=none; d=google.com; s=arc-20160816; b=Sz8/3lBO+kdSSjc6WsYE/ZE3+eE7fBaF8TeLB06/PAJ5bMuo2SeS0MDH9+tjcm+Xa+ bV8xNnc95RRpoQxqmuBbyXh4ew/2/YrHWTUGCmV3Q5JEjmTlrk06Wogfb1ZwPFZQma4g kICzkVrHYP/pdA92cwB2G5bhNoAZWmC/5tGHAnXySKCeoTBHIBeL4MGD/JjS39CDRNet 7Gw/5Xrz2rGYALTiBCIkWxbr4HSG75y3j1mMN7r3lWB2gjoHtwod8BBpoi+nh9CnkVA2 bIJK2NECYH4aiQ9IMdsfgT+lk6hiO+6eklB2jneg1BTM4siwSRn5kzsr9xTgxenF2Pde HHzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=rQOvQgcwSGhsx83zuwOIMEfyRSxfldKUWJMK4smLlTk=; b=B+wqKzhGHgkJOogpBOmhYxXMu9iXo9fNn3syOe80z0comKBbC9PHK+5M097QOfHVaO CrwOL06kPBTDXoqlafJw0YYTEReyNTm/ywjeOfirEzAURR6tVAH+SkVGPhhOFPD7EaP1 cMHH90pB3MRstCAzfkMKUeWzDF6hbsLdhpa9Hg1RN/DBOGuKsNkCC2z/x6H8qIVn5W5K 3Bv7E/ST0FN78cHC2DRwXCEafgWnjzr1vKeEuxwcfjoK8+5pzvV4E4TBWsRBWqILK8kn uv4KwK5+NR/qrQvZSOaTG16xwvzidsyeQBLwpPi/J+QK8DkVZw8liAxtsEKBCN1uDrc/ CKyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TGCC0lg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g8si11938847ejm.497.2020.11.10.14.18.32; Tue, 10 Nov 2020 14:18:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TGCC0lg2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731558AbgKJWOA (ORCPT + 99 others); Tue, 10 Nov 2020 17:14:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732112AbgKJWNx (ORCPT ); Tue, 10 Nov 2020 17:13:53 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DCCC0613D1; Tue, 10 Nov 2020 14:13:53 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id q5so147172pfk.6; Tue, 10 Nov 2020 14:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rQOvQgcwSGhsx83zuwOIMEfyRSxfldKUWJMK4smLlTk=; b=TGCC0lg2sZQc6r3ePjIXxtW0nsA2Kt6Cm4hO8KDykChbWjo8mbydvW3ZwT6ZKPgEjT uxCAhZQLeMBwM1TtzoRN4EJ4ZteU2ulWSlwRYNtDskRG2lD4umWPYf3XrWNxrZFOpHv7 lGDIHTTJhLNRLZu/9k9LPvXChItQlDo4t/JXBG8Iy+m0lGudBYpSou4p/SVq0aY45usO nyH92f0rltgkSSlRCmH8EeYpFnBZBKVqnZQNPtgQf3c1Dhf664si1OAX4cLEG2+G/llU LDduQJUUELs7tJba7Sq6ouMOSAmWs1NdcUfHDD9RSX2gCsNTJ8t2YejHRxKx3c8aHVbu IEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rQOvQgcwSGhsx83zuwOIMEfyRSxfldKUWJMK4smLlTk=; b=qP/pX9z57PF3niMN4v9tiLcSZu9Am3vUgNp50Uuogtcn3LgGRtPK0iiKj9pNu1BPgs JWihUBgKYevhfb8chqrPDdbJifs7T7tIx3QVF355gVzzF0zmY5KdesVdWtToTulE7eh7 iL0Ebrl5bhCblHiTbmFxtzlOsuF5I8JNq/gMO22dgT+B/ZshFagETK+Q40lsGeMt3i3B X3GGCXV2LKhHPbEYT/+Vj6S4roMxBGfY585cm+ZEDNVIhhhY5KgCTR0cScRMnkXZT9OE w+0HvDPeQbCHPZrOx7vr6Dd5p5SEQMYoiQq+AXrXQlSKuBHcqM+vD+auOB6/PPdbm3hl Wqhg== X-Gm-Message-State: AOAM5300tHgLGTGcijC+Pko4W2qqT1lnMq5vOQX8jYM32CUCfeRTXZ7Z dfeLlSi3lM1HfdfNKsATO44= X-Received: by 2002:a17:90a:9c5:: with SMTP id 63mr260660pjo.195.1605046432496; Tue, 10 Nov 2020 14:13:52 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id h20sm1913pgv.23.2020.11.10.14.13.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 14:13:51 -0800 (PST) Subject: Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node To: Vladimir Oltean Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-6-f.fainelli@gmail.com> <20201110221221.4sxx5h3346no7y3y@skbuf> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <3e87038f-9e2e-676c-a000-0e6c0e8b6ae4@gmail.com> Date: Tue, 10 Nov 2020 14:13:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110221221.4sxx5h3346no7y3y@skbuf> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/20 2:12 PM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: >> Provide an empty 'ports' container node with the correct #address-cells >> and #size-cells properties. This silences the following warning: >> >> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: >> ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: >> 'ports' is a required property >> 'ethernet-ports' is a required property >> From schema: >> Documentation/devicetree/bindings/net/dsa/b53.yaml >> >> Signed-off-by: Florian Fainelli >> --- >> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >> index 807580dd89f5..89993a8a6765 100644 >> --- a/arch/arm/boot/dts/bcm5301x.dtsi >> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >> @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 { >> status = "disabled"; >> >> /* ports are defined in board DTS */ >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + }; > > This look a bit 'lone wolf' here. Not sure how much time you intend to > spend on this, but FWIW, others prefer to declare all ports in the SoC > DTSI with status = "disabled", and just enable the ones used per-board, > and add labels and PHY handles also per-board. Example: fsl-ls1028a.dtsi > and fsl-ls1028a-rdb.dts. That's a good suggestion, I could do that. -- Florian