Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4356493pxb; Tue, 10 Nov 2020 14:30:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1ntCdstT9yVo5a4G1kfJttXxocO62AIzvr7CpGoVyI7dRQ0OaY1eq/7fOtgEMdWwT766x X-Received: by 2002:a17:906:1383:: with SMTP id f3mr21839834ejc.489.1605047403466; Tue, 10 Nov 2020 14:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605047403; cv=none; d=google.com; s=arc-20160816; b=JEGjJIVIX9c+sIJd/Q+/ZReLEuXZ2j2Ku+MF/MDS6GHFdcWJGj9J0r7gaKFlZoS5E/ FTyZ+yorQxF9Vay0jC/stV3L3z3xkN1/qNQ+taTas7FLQlK845NgqW1JNN/Yam6EWRKk NvI/DSV9AWIi4H1VPUCIyQPrxiCJRTtqTCZSfcZ6kZud6t0sx2CaGpCZipmASZksy9Hu QDX62GanAOlQvxVOYYmueOcfXVkCLnmUCEUVCaF/EP3H2YeLV1rm7mh1RlRLNxR148m/ 1ufWaFagq9naRKOpNs0NGHiXSno3W4cnplhOmmCiGynQCRJsvElgFidw19TbC9TmHyen BzVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IDwqcl49mFRj/GQI1sIJo5TSDn2DCgIJIB4tlo20bkQ=; b=Fi5hpjzp3Oiqihr8pg5dxMNoHHoGZFnv1yvaoLoHsgdIt8ab2fIFmtUCHmIn60r0IE GQEPtU0+OgxChhPri/hOw2SyMovNpjfT/5/3xFx/SLvNbeIK1RRA/14zR0/Fj9npWF15 8efE3OtN183QKYklPR1rLHtNhB8qoGuyX2LlAzhq8wkPjlw3DCZTEE9vRyeaZmwYoOXY QSRRnXFoH/gvVMqvnz0yVHymgwhoJuJQkgRYSCx2Lxo29cChrzd2MWnCGOIs/TC2qB1Y Y1o+ulYBGdlsejkpBhMXiWE9MhvU9leJVZvFO5rI33KWiW0uWkgr95HCnoMqq94SdWNa Joew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NFxx6otC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc8si3899ejb.278.2020.11.10.14.29.39; Tue, 10 Nov 2020 14:30:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NFxx6otC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732328AbgKJW2B (ORCPT + 99 others); Tue, 10 Nov 2020 17:28:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732432AbgKJW2B (ORCPT ); Tue, 10 Nov 2020 17:28:01 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02DDC0613D1; Tue, 10 Nov 2020 14:28:00 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id f20so14187ejz.4; Tue, 10 Nov 2020 14:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IDwqcl49mFRj/GQI1sIJo5TSDn2DCgIJIB4tlo20bkQ=; b=NFxx6otCj2aPXrKIQ10imsjVP+bu3Ha8B8pCjqD7c/YYYL6VjsGsg+53t0mqr3fq0B RuoDT4ebf6LgEL3U9BIUAS2OBwTzvo5j88HOJK70B1nbKOSDB1UJ3cp6j8gvi2oF9701 ImgGKDgSjI58Qwyb43wv7Hx7s3w7fUDNLLwnMhenIQtDqCw9WdmVoSA8MHc3r/GQHWvX krUrD9kcICk3hfSgqyytYgdsxfguZ8uCcKYAQKDS8fOJaNc3FcEM5C3SHFr0wsTSILJ/ Qw3y5/HALBizYwW4uGyDKF/ctXaq9Y4dTcixxyY2u0umFDqfXi4ABp6nYGdEFeAaosDb nm2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IDwqcl49mFRj/GQI1sIJo5TSDn2DCgIJIB4tlo20bkQ=; b=c/+XtRzMng0MW7Y66YRUA2jm2sa+NT8j52ymIdmwUAsMlag8W5Ng9RFWST2qH4Y8Pz orJO45G62TNiTQsdQ43NT1WFOO0q+rTPyjkogWy5yCMUFyWZi/8nOnY4JhBPFXXa1Cwg KJUs3vP0hm6TU+hug6tzQb3WrqCgvpmV15BM7RqNyxv7ByDisPNDHeH/UdlHRJ1xVXWP 7wWJFFR1GPOlLXHqLbYLxKZDk4q9/zVspkgTmdRM2sGGdDauBao2NeCn4OkZzrgCuxxK yvNxW6xy2B6rVrMxUuO0M/CBYHm0Iwg6Azegvly0XbYv0MgP90VYG8Fewv6NouJJlJUk tdLQ== X-Gm-Message-State: AOAM531wecw//lsLDrUhgcA5tWCz6aTlFBH0hatR3vnO8Gf5dIltg8Vc Xl0tubnEIvph/tfb/39vZCSqJZDvX/Q= X-Received: by 2002:a17:906:3a4e:: with SMTP id a14mr21936517ejf.140.1605047279356; Tue, 10 Nov 2020 14:27:59 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id b24sm16440edt.68.2020.11.10.14.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:27:58 -0800 (PST) Date: Wed, 11 Nov 2020 00:27:56 +0200 From: Vladimir Oltean To: Florian Fainelli Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach Subject: Re: [PATCH 07/10] ARM: dts: NSP: Fix Ethernet switch SGMII register name Message-ID: <20201110222756.alaii5mr6fcwq4lx@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-8-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110033113.31090-8-f.fainelli@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 07:31:10PM -0800, Florian Fainelli wrote: > The register name should be "sgmii_config", not "sgmii", this is not a > functional change since no code is currently looking for that register > by name (or at all). > > Signed-off-by: Florian Fainelli > --- I.e. no one calls devm_platform_ioremap_resource(pdev, 2), and even if it did, the register name wouldn't matter. ...but at least it's documented that it should be called "sgmii_config". And the address is the same as the one that's documented for the SGMII register base in SoCs with "brcm,nsp-srab", so even without documentation, it is pretty clear to me that it was a mistake calling it simply "sgmii". And if that address is incorrect anyways, at least that would be a separate issue. Reviewed-by: Vladimir Oltean > arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > index e7d08959d5fe..09fd7e55c069 100644 > --- a/arch/arm/boot/dts/bcm-nsp.dtsi > +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > @@ -390,7 +390,7 @@ srab: ethernet-switch@36000 { > reg = <0x36000 0x1000>, > <0x3f308 0x8>, > <0x3f410 0xc>; > - reg-names = "srab", "mux_config", "sgmii"; > + reg-names = "srab", "mux_config", "sgmii_config"; > interrupts = , > , > , > -- > 2.25.1 >