Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4364213pxb; Tue, 10 Nov 2020 14:45:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrwmJy5Rb1mkN+5LqH2E79UlPNb/dW6Qq7gorTSqae5qbU4w6AzQ1JhOHF66ZxGCcSomG6 X-Received: by 2002:a05:6402:43:: with SMTP id f3mr22790741edu.373.1605048348209; Tue, 10 Nov 2020 14:45:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605048348; cv=none; d=google.com; s=arc-20160816; b=AOq29PgQuJOWpqYyB4bv4PuoAAyPBqkl5pVzif9iiGfyFjK66VaMLVxqoHIJ1wWog3 xe99A/AVnTGwDVz/Bufki5ITyLhqi+IG4qK0kqeUgCDcwhFayr/YWlEkGlH/toXNllMI v1KvQM2LhHOglwwAqJOYY1i5ASM6LJvqMN/BARBGLISnzdGFT0Rny8pa15ix9AllXhs/ HPygaRbY/GVGg8yFjOhi4PndKx/I39umZh0yb1P4YOrY3ReK7EuSSrI4YVY/5/txNh9o EaV5xsui69J0b3YWmBq7eOKyBUTaXETSCERMr+t1laWuCK8XxcOYXinUGaftos4hAOY9 eY2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=lKF1Y/LvIELJ5+wQfpktaSsqggL2YurPAxT0fmlKuoM=; b=uuIiayzQ8GVIpNLpQDWuZWz6HM+YxS6cBUN1nvTqum2qNwhjDJcRvg6Bb9K/74OiEo 2+H/VycOtuFsvE9HjiyixMRFTMUPW8hq8R7pbmKu0YFsebSfXFcm/WEslY56gye3tu5K m5kVeriZ99v4pBrOu0IfA6LkLo6TW8g5d3MjeUtjhc++J8NdUDayKENUUAtDvCH+I7QD suBqNRscSvCmChdKFcJWjskkI1rStWV8mK3DFxPWOlOlcZSSKcCXlT25WH8ivp3doC8P tAQMOzk9z3Y+dtcMsAgOi0YqtuC7NVxDNQe38IxwLaARKRj+McTUG63u4fBk9Wbw5GfN 3t0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="q7URj/6q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n25si111796eda.43.2020.11.10.14.45.22; Tue, 10 Nov 2020 14:45:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="q7URj/6q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732175AbgKJWkt (ORCPT + 99 others); Tue, 10 Nov 2020 17:40:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730254AbgKJWks (ORCPT ); Tue, 10 Nov 2020 17:40:48 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1EFC0613D1; Tue, 10 Nov 2020 14:40:48 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id e21so11514814pgr.11; Tue, 10 Nov 2020 14:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lKF1Y/LvIELJ5+wQfpktaSsqggL2YurPAxT0fmlKuoM=; b=q7URj/6qHU1ZNZsGC8ySoKleadCCQmMMWdLN1U9Wr6sijbRgUnOZJCzeYMGJv1qNX+ eH5a0zdFtDaBVilI8QbCzYwzeyeQ+Zfj8x+RWkdhYHLE00RioABfHw/M3sjyjiPNXI/y jUM0jhcLCNyXpOUZyqJ41Y/S0HofjMDtnG/w06JahAGKBMZqwH3nV4pEOUTu9Gq3fY+w V7XWVGN5MoA2d/dp2in6jmV0AgqEB6dH7JeV9fs7jgPAZCLkkv7PrSmIHzJi4yvIyX16 vTK3koj3ySqP+ooR4FfC41bjRJRxpt58tC4OvKFpfb0YYlRVQAiwlZDf1SUQxKaSZ5ZD jExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lKF1Y/LvIELJ5+wQfpktaSsqggL2YurPAxT0fmlKuoM=; b=SKc1WZwEVIpkEIY3EfEvdshLwpZY0hL9q5kwc1wLYO4/f0cIG4MWB1Q+9f8LYqAIVq fSjDuelj9pN081SbJd+fHpM+A4pKsVZorIm9/6kPJALZztFFUznV/0aoOz2tigYFZNei M0GwYGrkzEiUnfhYIz8DPxvNE08dlEHSIGrV5Pwka5ghHQt0UJPQ26LMnI6a8tUl3gyh SRn1il9oHdt2UCrNHvfPEnSzMpfTV2wOWwamKQkQSK/PQsURl+fHrm9OAziVZKFMNo+a +4yvEsb6UPlFOS6vBwFLnHVyT6jc+pPwZXo09arlvh2cJ9TV/+uubebUs+BbdZ+GFDmx Dmng== X-Gm-Message-State: AOAM5330uth/ogg70fbM6Qjw8j8BTJafgIPn8nUjRd0lOafzGS+TjEJD OuuFxI8UmkbiZssNgNU3wjo= X-Received: by 2002:a17:90a:9504:: with SMTP id t4mr443218pjo.82.1605048047529; Tue, 10 Nov 2020 14:40:47 -0800 (PST) Received: from [10.67.48.230] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id f4sm5123550pjp.3.2020.11.10.14.40.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 14:40:46 -0800 (PST) Subject: Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node To: Vladimir Oltean Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-9-f.fainelli@gmail.com> <20201110223709.vca534wynwgfkz77@skbuf> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 10 Nov 2020 14:40:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201110223709.vca534wynwgfkz77@skbuf> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/20 2:37 PM, Vladimir Oltean wrote: > On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: >> Provide a default compatible string which is based on the 58522 SRAB >> compatible, this allows us to have sane defaults and silences the >> following warnings: >> >> arch/arm/boot/dts/bcm958522er.dt.yaml: >> ethernet-switch@36000: compatible: 'oneOf' conditional failed, >> one >> must be fixed: >> ['brcm,bcm5301x-srab'] is too short >> 'brcm,bcm5325' was expected >> 'brcm,bcm53115' was expected >> 'brcm,bcm53125' was expected >> 'brcm,bcm53128' was expected >> 'brcm,bcm5365' was expected >> 'brcm,bcm5395' was expected >> 'brcm,bcm5389' was expected >> 'brcm,bcm5397' was expected >> 'brcm,bcm5398' was expected >> 'brcm,bcm11360-srab' was expected >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', >> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', >> 'brcm,bcm53019-srab'] >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', >> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', >> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', >> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', >> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', >> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] >> From schema: >> Documentation/devicetree/bindings/net/dsa/b53.yaml >> >> Signed-off-by: Florian Fainelli >> --- >> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi >> index 09fd7e55c069..8453865d1439 100644 >> --- a/arch/arm/boot/dts/bcm-nsp.dtsi >> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi >> @@ -386,7 +386,7 @@ ccbtimer1: timer@35000 { >> }; >> >> srab: ethernet-switch@36000 { >> - compatible = "brcm,nsp-srab"; >> + compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; >> reg = <0x36000 0x1000>, >> <0x3f308 0x8>, >> <0x3f410 0xc>; >> -- >> 2.25.1 >> > > I am not getting this. > The line: > #include "bcm-nsp.dtsi" > > can be found in: > > arch/arm/boot/dts/bcm988312hr.dts > arch/arm/boot/dts/bcm958625hr.dts > arch/arm/boot/dts/bcm958622hr.dts > arch/arm/boot/dts/bcm958625k.dts > arch/arm/boot/dts/bcm958522er.dts > arch/arm/boot/dts/bcm958525er.dts > arch/arm/boot/dts/bcm958623hr.dts > arch/arm/boot/dts/bcm958525xmc.dts > > > The pattern for the other DTS files that include this seems to be to > overwrite the compatible locally in bcm958522er.dts, like this: > > &srab { > compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; > }; > > Is there a reason why you are choosing to put an SoC specific compatible > in the common bcm-nsp.dtsi? It is necessary to silence the warnings provided in the commit message even when the srab node is disabled, since the dt_binding_check rule will check all of the nodes matching the pattern. If there is a better way to do this, I would gladly do it differently. -- Florian