Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4367483pxb; Tue, 10 Nov 2020 14:53:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxLCdyygg+44LbnohZLNViUFwDvTTz8/gFm2z7uhJOT/HawYrZbZyBQ0jQlniDEIwqhinx X-Received: by 2002:a17:906:1c83:: with SMTP id g3mr21900858ejh.168.1605048797593; Tue, 10 Nov 2020 14:53:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605048797; cv=none; d=google.com; s=arc-20160816; b=k5JkuwMT10ebyFrhqDceWdxnoxMnPckvLvY5lqzvndV9xJ1ws57YhOwWr1sWNG+ksK fZJDo/JK7zNp6wx4QhiLrIjw6Z/6y4LHCtbAobZcgtGgMwwmZ6aJVN0o7Zk5vEjCgQpu l7ipaQKEPK+fnjLe/sT0x7HcL1drTq9TvDDBu+Oxbi5imJBTjUr2AkGpgBTlWfhLSFEl vIxwHAWfNJAxKPCB30EwfVvlUX6YLvW59AlfaVnPIxO3XXF9qYD2pZ6erdiJMW3HfY/G Gh2ANseNsli7kn0n1rZdK/28rhZDsnlhEt83h9uf8ThzLoagD3GKY830MXdfOXeH+D3f I0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Em8WmoYAvsXVW5SzBtkWgE8omnO3+c4rMhoVObwwjsk=; b=M9dn1lwEAaU8kyd0MZ4WqAgxg9YvPIBOSTJ27nywTgVcBwg+aB0CTyryxuhh10S/eX G5XnGWBikIr9fa3M2Rjuv+C+nXHeLhlvuL6wnaLGTTuds0nangQ72AEfx/O3WwCUhtmw vHiIUxU4EyppI/eWdGoeesTzoywplAylb6+zlrZ4OTdZVAmf72SgAQ4d98eOmxhe+sYM HZoTz/+KO8P936npM+wjJSCZNu5rRxuAtSQemn+wNLvRMIuvFT1th96Ct7Pp44ORcuI9 aloW1hdyOe4eb6F9vcEIDzKOdriOmef3GuOLIIynPyAL2JOtUGvqB09nvtzquEjCoB8M xCmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lxv2PaOv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x9si12146ejy.403.2020.11.10.14.52.44; Tue, 10 Nov 2020 14:53:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lxv2PaOv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732312AbgKJWs2 (ORCPT + 99 others); Tue, 10 Nov 2020 17:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726688AbgKJWsZ (ORCPT ); Tue, 10 Nov 2020 17:48:25 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1329BC0613D1; Tue, 10 Nov 2020 14:48:24 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id l5so177962edq.11; Tue, 10 Nov 2020 14:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Em8WmoYAvsXVW5SzBtkWgE8omnO3+c4rMhoVObwwjsk=; b=lxv2PaOvwPDyJPfCeBZHoeHvFyarLc7JGIvHAfhVDSy6drxmEHL4vhm3B2Ysu1UfhU NspZc78ZfwNzl1SRzdTRcoAkri5QzHOrN1GySZd+otwHlcHXcdProhZ6a8XlM6TXWd+k i8O2ilk1nH2d5bLo/H0lBT4tKnAMY7CPjGgD+9bDeeVayedKjY2J3eOMBVoJMHf+8gR5 wXHxTE65VZVgJv+w0qwYEFi97velqUluljCcA3spM2lAPdSflyuJly69pcCxb/vaoPMm EO4EeJ6I6GnqBiN0i1GgejfiFST4OChxG1OBv4vqHL1kPvgwSosXLJtkqHApAVAfHTEI FUNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Em8WmoYAvsXVW5SzBtkWgE8omnO3+c4rMhoVObwwjsk=; b=heK5KwUngeex/fyDxZjpYxpVCW7JnufykocFkWqo00kau12vO10Z/irL+Xn6Tq388V a3hFzvT5qEXkEwPYRvI7B4fVQE3+MeAgfh8BXJ3mKHHnkeuaSXmgrZUYJdPC9jiF7lzI RODJxoCiW2/doBfBp5iCyyPz7y87FJoHFl/um03eEE/owHPc71BjQFYgvHTqttxE8uPU eQeJg3zr3a70RQN5gNlbZ5MUN+mjMG58ZAOBWpHYtw6Wvhw7jroz/lz7bpofNJVMedVl JHhdz4jhQcN/hpCO5UEnIWZbMMp0AUfigxLevHkzdzfYeKGckcgAE3cchyXYyR4k8IWl RIRA== X-Gm-Message-State: AOAM5318q2xEnc8G89YSh8+QlRk4ikk4sNI96Qgcey4Z7b14bwW8F6Tf EL9vC27V/XkiB7C+/9qfttk= X-Received: by 2002:a05:6402:783:: with SMTP id d3mr23885455edy.168.1605048503378; Tue, 10 Nov 2020 14:48:23 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id a17sm37417eda.45.2020.11.10.14.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 14:48:22 -0800 (PST) Date: Wed, 11 Nov 2020 00:48:20 +0200 From: Vladimir Oltean To: Florian Fainelli Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach Subject: Re: [PATCH 08/10] ARM: dts: NSP: Add a default compatible for switch node Message-ID: <20201110224820.gbz3tcl6lzjbe3zo@skbuf> References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-9-f.fainelli@gmail.com> <20201110223709.vca534wynwgfkz77@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 02:40:43PM -0800, Florian Fainelli wrote: > On 11/10/20 2:37 PM, Vladimir Oltean wrote: > > On Mon, Nov 09, 2020 at 07:31:11PM -0800, Florian Fainelli wrote: > >> Provide a default compatible string which is based on the 58522 SRAB > >> compatible, this allows us to have sane defaults and silences the > >> following warnings: > >> > >> arch/arm/boot/dts/bcm958522er.dt.yaml: > >> ethernet-switch@36000: compatible: 'oneOf' conditional failed, > >> one > >> must be fixed: > >> ['brcm,bcm5301x-srab'] is too short > >> 'brcm,bcm5325' was expected > >> 'brcm,bcm53115' was expected > >> 'brcm,bcm53125' was expected > >> 'brcm,bcm53128' was expected > >> 'brcm,bcm5365' was expected > >> 'brcm,bcm5395' was expected > >> 'brcm,bcm5389' was expected > >> 'brcm,bcm5397' was expected > >> 'brcm,bcm5398' was expected > >> 'brcm,bcm11360-srab' was expected > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm53010-srab', > >> 'brcm,bcm53011-srab', 'brcm,bcm53012-srab', 'brcm,bcm53018-srab', > >> 'brcm,bcm53019-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm11404-srab', > >> 'brcm,bcm11407-srab', 'brcm,bcm11409-srab', 'brcm,bcm58310-srab', > >> 'brcm,bcm58311-srab', 'brcm,bcm58313-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm58522-srab', > >> 'brcm,bcm58523-srab', 'brcm,bcm58525-srab', 'brcm,bcm58622-srab', > >> 'brcm,bcm58623-srab', 'brcm,bcm58625-srab', 'brcm,bcm88312-srab'] > >> 'brcm,bcm5301x-srab' is not one of ['brcm,bcm3384-switch', > >> 'brcm,bcm6328-switch', 'brcm,bcm6368-switch'] > >> From schema: > >> Documentation/devicetree/bindings/net/dsa/b53.yaml > >> > >> Signed-off-by: Florian Fainelli > >> --- > >> arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi > >> index 09fd7e55c069..8453865d1439 100644 > >> --- a/arch/arm/boot/dts/bcm-nsp.dtsi > >> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi > >> @@ -386,7 +386,7 @@ ccbtimer1: timer@35000 { > >> }; > >> > >> srab: ethernet-switch@36000 { > >> - compatible = "brcm,nsp-srab"; > >> + compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; > >> reg = <0x36000 0x1000>, > >> <0x3f308 0x8>, > >> <0x3f410 0xc>; > >> -- > >> 2.25.1 > >> > > > > I am not getting this. > > The line: > > #include "bcm-nsp.dtsi" > > > > can be found in: > > > > arch/arm/boot/dts/bcm988312hr.dts > > arch/arm/boot/dts/bcm958625hr.dts > > arch/arm/boot/dts/bcm958622hr.dts > > arch/arm/boot/dts/bcm958625k.dts > > arch/arm/boot/dts/bcm958522er.dts > > arch/arm/boot/dts/bcm958525er.dts > > arch/arm/boot/dts/bcm958623hr.dts > > arch/arm/boot/dts/bcm958525xmc.dts > > > > > > The pattern for the other DTS files that include this seems to be to > > overwrite the compatible locally in bcm958522er.dts, like this: > > > > &srab { > > compatible = "brcm,bcm58522-srab", "brcm,nsp-srab"; > > }; > > > > Is there a reason why you are choosing to put an SoC specific compatible > > in the common bcm-nsp.dtsi? > > It is necessary to silence the warnings provided in the commit message > even when the srab node is disabled, since the dt_binding_check rule > will check all of the nodes matching the pattern. If there is a better > way to do this, I would gladly do it differently. > -- > Florian I am still not getting it. The exact 3 lines from above will not change the "status" property from "disabled" to "okay", so I don't understand why it matters whether it's enabled or not. The dt_binding_check error isn't in the DTSI, it's in bcm958522er.dts. All that needs to be done is that the bcm958522er.dts needs to override the compatible from the DTSI and only the compatible, I believe. With no occurrence of an incomplete list of compatibles in any final DTS, the dt_binding_check should not complain about that single occurrence in the DTSI as far as I know (and I did not test this).