Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4390570pxb; Tue, 10 Nov 2020 15:33:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3BJEDwaMshn2Hi2fGubN8QzNPzwYe6INh0mzOwKOwtJEZgOiq5eGErUeX3aqZZ8bw0d71 X-Received: by 2002:aa7:d8c4:: with SMTP id k4mr1940312eds.248.1605051198673; Tue, 10 Nov 2020 15:33:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605051198; cv=none; d=google.com; s=arc-20160816; b=pV9w9TBlHIXjaoV9P5EIiw87qTqto8DlkM+j8OIrhVzGFuLA9EEEciRx143RD76PjG lQib7xXsin/+4ASXyvdmAOvwMl9VEMt+GNJ8NQc7AfEVT3e3Umkf4NzDUqrUsvroi+r8 2K9xTbg0DaDJQ8Msj/iIOqHvnEwCsudv7jfuWA/RiiURqaVyAHPFtKI2tpPlAmJUEsae AqfFJBa0j3pw0orYAuuU/WUwtb7L7Ayv2mS7i1je6YPCBd5KNbPaNUVG96ixZYfRflwv b+V1PB0RivSfBOJDhRm0kBXOdRQLwblotxmDAvys/Iu2aOyb66BVZrOrTBvjLFpotjf4 z0JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vNgwX4aGg6M5WjZDNK6SbunDynG49UjDj/bXWVWDYS4=; b=RT2PTOHCV6ZlRO03QxFdw7U1YwifF5b24FDV1OukCssDmGoFV16mFmiGzaIEFCLr5F BI8c56q3zb5GpLF+KuUtAqCb9JqBo990uBHPMgRNSRcXcF/j0q9gB5Bm60m3HgGfaUxM /TsbNwa2+HgJA5Zglt2MUBiCr2/frocGZS7paHS8/tRF3lADK9cNdzfbu1bghtfsTENg JOLv+D5SFZkf4tRysltG/P4MIvuvLmXgrFrjxREnOH1O1ff1ZgCuLN0oRBe3ksCo+2JO KjxDS8VM340GvxUd8XihKtW6pWWMK3LZH21q6dUezzvXlvxKtLu1mF2umB8KKhkFCqOu jMJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j5fSaEU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u11si166238edp.431.2020.11.10.15.32.44; Tue, 10 Nov 2020 15:33:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j5fSaEU1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732236AbgKJX0D (ORCPT + 99 others); Tue, 10 Nov 2020 18:26:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:38018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbgKJX0D (ORCPT ); Tue, 10 Nov 2020 18:26:03 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EDC7D20781; Tue, 10 Nov 2020 23:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605050762; bh=gJjjMa0V5H+EAlYsHkzwK5YEswkJdBh8XP+DDSZC2U4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j5fSaEU1lH7h5ujWWG3S7Drs4YsUU/vw3I6Tn3RlSqGeNBa5WGU6k6SjnYzbWJiBe UfdBNBz0Ow7wCSq3CNev0UuaRV1EiyHP25iGKo2cV1EAQua/PiPHGs8HRb24utdDG0 F1amS/lj8rIGFoaFf2Uwips2/BHnsX+1MC46wAw0= Date: Tue, 10 Nov 2020 15:26:00 -0800 From: Jakub Kicinski To: xiakaixu1987@gmail.com Cc: irusskikh@marvell.com, andrew@lunn.ch, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH v2] net: atlantic: Remove unnecessary conversion to bool Message-ID: <20201110152600.40c919a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1604797919-10157-1-git-send-email-kaixuxia@tencent.com> References: <1604797919-10157-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Nov 2020 09:11:59 +0800 xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The '!=' expression itself is bool, no need to convert it to bool. > Fix the following coccicheck warning: > > ./drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1477:34-39: WARNING: conversion to bool not needed here > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia Applied.