Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp4448622pxb; Tue, 10 Nov 2020 17:16:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZ4CWo1IcGPVo47NpFwtodFGfFeFkHADNYpv/Y4u8R65t91BgFh9oAGTxzYeimmRJFaB/5 X-Received: by 2002:a50:fe18:: with SMTP id f24mr2312648edt.162.1605057369352; Tue, 10 Nov 2020 17:16:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605057369; cv=none; d=google.com; s=arc-20160816; b=N+eFN7etlm5U0khqDJIFvADl118Zf9qii4EDAte5W0LxNFf/Dpuoy5S8Xl8KfntnZC 0gEzuczwjOMbNx8ts5yAQ4v4xX2aBdWkG65N3iVrPgDiv2bIc0i1bFLx/RheYX+Sdsql e0Se4UrQoMrD9VVTT6Kk0aI2uJcrAOsZreMct+1WTplHMSxlC6KhSaix2mnT4nFviU4P IxbaeniwN1o4r09HrpbmxgNaLSiJgQCNZfC+2wJ17r/RwHYAXgeztNq60sD4VXZsxQjY SzNwoTTrA2wapN08xm7vAoOky3VvVFR+6bA19XeuPBKL+TF//RhIJ1Nc7V9Z3xJtHtG6 ikag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=wN1C3tnMqnP5CnKUK3PfUqXx0govNltyNo/hvrBG++I=; b=WL9NdU4GJb/L5SoWN5A9mizG4emvjvF/ldToW684cFxmpre+nnmiiGJaGFxM5Jka/d 85fB1ZtN+HIjX7+9XQ4ZLU8AEddGqO0jKNL5AM/ZPQyrl2n0pf6zF8zv6ufajIir6AMf zkhEa4hYJEma4oafJU3YrNSNLSzr+cSPAtI1Rd08qepty/VIrHlaD5tj4beKJDfOohX7 dWUvCPk9m6yhGin+sr9HGB+lDU0yBegsziT/sRZB8Ef405PebbDqGUNT/ANlNGPFGaIg lTbAmy1AXgXJ04RgcQB6bdCN03bXo1EYnLZrspDDSAQBMguynNGJ3DfkTJYJHJK38PVv NejA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JtN9dD0r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si258514ejb.369.2020.11.10.17.15.33; Tue, 10 Nov 2020 17:16:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JtN9dD0r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732086AbgKKBNP (ORCPT + 99 others); Tue, 10 Nov 2020 20:13:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:53070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730254AbgKKBNO (ORCPT ); Tue, 10 Nov 2020 20:13:14 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A665121D46; Wed, 11 Nov 2020 01:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605057194; bh=16HYItG66V6WU6c8Fdsuoluq41PtqwCa8Bv4xeZylqU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JtN9dD0rF8ioMSqxieYhOX4Mr+CeKMan82/WjchZ9p/arWP7hUmdGCmiLeZFhddxc 4Em1rQ7s2BGmpre8+UdEjk8U817DN3ceiKhYiY6DQXEsSKijGrRx9FnXWHeKrgNuVN NqjUuzP86XY32cEikSUSSJJIulzQeNoux9ieZgXo= Date: Tue, 10 Nov 2020 17:13:12 -0800 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , Subject: Re: [PATCH V2 net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting Message-ID: <20201110171312.66a031a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1604892159-19990-2-git-send-email-tanhuazhong@huawei.com> References: <1604892159-19990-1-git-send-email-tanhuazhong@huawei.com> <1604892159-19990-2-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 11:22:29 +0800 Huazhong Tan wrote: > + if (rx_vector->tx_group.coal.ql_enable) ^^^^^^^^ Is this supposed to be rx_group, not tx? > + hns3_set_vector_coalesce_rx_ql(rx_vector, > + rx_vector->rx_group.coal.int_ql);