Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751819AbWHUJxf (ORCPT ); Mon, 21 Aug 2006 05:53:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751820AbWHUJxf (ORCPT ); Mon, 21 Aug 2006 05:53:35 -0400 Received: from mtagate6.uk.ibm.com ([195.212.29.139]:44179 "EHLO mtagate6.uk.ibm.com") by vger.kernel.org with ESMTP id S1751818AbWHUJxd (ORCPT ); Mon, 21 Aug 2006 05:53:33 -0400 Message-ID: <44E9829B.7010503@de.ibm.com> Date: Mon, 21 Aug 2006 11:53:31 +0200 From: Thomas Klein User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: Stephen Hemminger CC: Alexey Dobriyan , Jan-Bernd Themann , netdev@vger.kernel.org, Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein Subject: Re: [2.6.19 PATCH 4/7] ehea: ethtool interface References: <200608181333.23031.ossthema@de.ibm.com> <20060818140506.GC5201@martell.zuzino.mipt.ru> <44E5DFA6.7040707@de.ibm.com> <20060818104547.5ad1352f@localhost.localdomain> In-Reply-To: <20060818104547.5ad1352f@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1016 Lines: 32 Stephen Hemminger wrote: > On Fri, 18 Aug 2006 17:41:26 +0200 > Thomas Klein wrote: > >> Hi Alexey, >> >> first of all thanks a lot for the extensive review. >> >> >> Alexey Dobriyan wrote: >>>> + u64 hret = H_HARDWARE; >>> Useless assignment here and everywhere. >>> >> Initializing returncodes to errorstate is a cheap way to prevent >> accidentally returning (uninitalized) success returncodes which >> can lead to catastrophic misbehaviour. > > That is old thinking. Current compilers do live/dead analysis > and tell you about this at compile time which is better than relying > on default behavior at runtime. Understood. I reworked the returncode handling and removed the unnecessary initializations. Thanks for pointing this out. Thomas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/