Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wSD/yDbN6a5TIXVovTfVJsJ8/jV39BOZqelmcxH+5I4pzAD9/I3PjMYVmhzKGDd6FfX44Fpoxu
 UBA1v1T/cYhw==
IronPort-SDR: hGryR4Ni1m9yUzAm4dB8MG5hZM0pgD5ORjFZStwPm00NuM3hUemp8rge4SgdcbBstDIWJPxbSy
 WdhBKnsFoWNw==
From:   "Patel, Utkarsh H" <utkarsh.h.patel@intel.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "pmalani@chromium.org" <pmalani@chromium.org>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "Mani, Rajmohan" <rajmohan.mani@intel.com>,
        "Shaikh, Azhar" <azhar.shaikh@intel.com>
Subject: RE: [PATCH 4/8] usb: typec: Remove one bit support for the
 Thunderbolt rounded/non-rounded cable
Thread-Topic: [PATCH 4/8] usb: typec: Remove one bit support for the
 Thunderbolt rounded/non-rounded cable
Thread-Index: AQHWtvngzcAgg0YK1EqHP909A/hMtanBSZ+AgACAzCA=
Date:   Wed, 11 Nov 2020 01:38:44 +0000
Message-ID: <MWHPR11MB00485EFD8830E5D77B7B8193A9E80@MWHPR11MB0048.namprd11.prod.outlook.com>
References: <20201110003716.5164-1-utkarsh.h.patel@intel.com>
 <20201110003716.5164-5-utkarsh.h.patel@intel.com>
 <20201110121951.GM1224435@kuha.fi.intel.com>
In-Reply-To: <20201110121951.GM1224435@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 22550adc-bc47-4dc2-a982-08d885e286fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 01:38:44.5949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FW63qkjIXw6FqdudJqF+3ak/GwdOC/NgsPLl+GN4wLHWVlb4Am/wzDWii/AXryCPh9SRjugZeyrNR2IavuykwvzvqUoE0hhElmroL0XU3ck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4538
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heikki,

> -----Original Message-----
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Sent: Tuesday, November 10, 2020 4:20 AM
> To: Patel, Utkarsh H <utkarsh.h.patel@intel.com>
> Cc: linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org;
> pmalani@chromium.org; enric.balletbo@collabora.com; Mani, Rajmohan
> <rajmohan.mani@intel.com>; Shaikh, Azhar <azhar.shaikh@intel.com>
> Subject: Re: [PATCH 4/8] usb: typec: Remove one bit support for the
> Thunderbolt rounded/non-rounded cable
>=20
> On Mon, Nov 09, 2020 at 04:37:12PM -0800, Utkarsh Patel wrote:
> > Two bits support for the Thunderbolt rounded/non-rounded cable has
> > been added to the header file.
> > Hence, removing unused TBT_CABLE_ROUNDED definition from the header
> file.
> >
> > Fixes: ca469c292edc ("usb: typec: Add definitions for Thunderbolt 3
> > Alternate Mode")
>=20
> And again?

Ack. I will remove the fix tag in v2.

>=20
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> > ---
> >  include/linux/usb/typec_tbt.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/usb/typec_tbt.h
> > b/include/linux/usb/typec_tbt.h index aad648d14bb3..63dd44b72e0c
> > 100644
> > --- a/include/linux/usb/typec_tbt.h
> > +++ b/include/linux/usb/typec_tbt.h
> > @@ -39,7 +39,6 @@ struct typec_thunderbolt_data {
> >  #define   TBT_CABLE_USB3_GEN1		1
> >  #define   TBT_CABLE_USB3_PASSIVE	2
> >  #define   TBT_CABLE_10_AND_20GBPS	3
> > -#define TBT_CABLE_ROUNDED		BIT(19)
> >  #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \
> >  					(((_vdo_) & GENMASK(20, 19)) >> 19)
> >  #define   TBT_GEN3_NON_ROUNDED                 0
>=20
> thanks,
>=20
> --
> Heikki

Sincerely,
Utkarsh Patel.