Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: uDZlgfNU6xVsWX7t/1mOVEfez54Q1hvdAPyfBrhC8FvfuBa66iPzp1DP3Il5WhdS2/TtQrzm9R
 bvNgTsOPX1Qg==
IronPort-SDR: J+NGmDx0DDFP2y4z+dMjJ+pjKpUTPk1apVSAnObFU4HqKD31LHi00+bVliW7tbI3hi+xby6/dp
 w2HDKPVQZIEA==
From:   "Sia, Jee Heng" <jee.heng.sia@intel.com>
To:     Vinod Koul <vkoul@kernel.org>
CC:     "Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 09/15] dmaengine: dw-axi-dmac: Support burst residue
 granularity
Thread-Topic: [PATCH v2 09/15] dmaengine: dw-axi-dmac: Support burst residue
 granularity
Thread-Index: AQHWtn3mLZfDhbVLE06A4ls6x2Eq8KnCKx3g
Date:   Wed, 11 Nov 2020 01:44:23 +0000
Message-ID: <CO1PR11MB5026C04E7F8DA29F87268D3CDAE80@CO1PR11MB5026.namprd11.prod.outlook.com>
References: <20201027063858.4877-1-jee.heng.sia@intel.com>
 <20201027063858.4877-10-jee.heng.sia@intel.com>
 <20201109095115.GD3171@vkoul-mobl>
In-Reply-To: <20201109095115.GD3171@vkoul-mobl>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 149aa479-fd11-4f15-9cb5-08d885e350d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 01:44:23.2139
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0jBkcMaf9PS1A8hz3y9UbPS2vGN6536f1LHpWcRfn4z3loPRk0LNq5EIB8SItn9qiVtqGXzk0wmGSK2Tay3P/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: 09 November 2020 5:51 PM
> To: Sia, Jee Heng <jee.heng.sia@intel.com>
> Cc: Eugeniy.Paltsev@synopsys.com; andriy.shevchenko@linux.intel.com;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 09/15] dmaengine: dw-axi-dmac: Support burst resid=
ue
> granularity
>=20
> On 27-10-20, 14:38, Sia Jee Heng wrote:
> > Add support for DMA_RESIDUE_GRANULARITY_BURST so that AxiDMA can
> > report DMA residue.
> >
> > Existing AxiDMA driver only support data transfer between memory to
> > memory operation, therefore reporting DMA residue to the DMA clients
> > is not supported.
> >
> > Reporting DMA residue to the DMA clients is important as DMA clients
> > shall invoke dmaengine_tx_status() to understand the number of bytes
> > been transferred so that the buffer pointer can be updated accordingly.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Sia Jee Heng <jee.heng.sia@intel.com>
> > ---
> >  .../dma/dw-axi-dmac/dw-axi-dmac-platform.c    | 44 ++++++++++++++++---
> >  drivers/dma/dw-axi-dmac/dw-axi-dmac.h         |  2 +
> >  2 files changed, 39 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > index 011cf7134f25..cd99557a716c 100644
> > --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c
> > @@ -265,14 +265,36 @@ dma_chan_tx_status(struct dma_chan *dchan,
> dma_cookie_t cookie,
> >  		  struct dma_tx_state *txstate)
> >  {
> >  	struct axi_dma_chan *chan =3D dchan_to_axi_dma_chan(dchan);
> > -	enum dma_status ret;
> > +	struct virt_dma_desc *vdesc;
> > +	enum dma_status status;
> > +	u32 completed_length;
> > +	unsigned long flags;
> > +	u32 completed_blocks;
> > +	size_t bytes =3D 0;
> > +	u32 length;
> > +	u32 len;
> >
> > -	ret =3D dma_cookie_status(dchan, cookie, txstate);
> > +	status =3D dma_cookie_status(dchan, cookie, txstate);
>=20
> txstate can be null, so please check that as well in the below condition =
and
> return if that is the case
[>>] noted. Will factor in the null condition check in v3
>=20
> --
> ~Vinod