Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/5] add KERN_LEVEL to printk
To:     Bernard Zhao <bernard@vivo.com>, Rob Clark <robdclark@gmail.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jordan Crouse <jcrouse@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Brian Masney <masneyb@onstation.org>,
        Shawn Guo <shawn.guo@linaro.org>,
        Eric Anholt <eric@anholt.net>, Sam Ravnborg <sam@ravnborg.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Emil Velikov <emil.velikov@collabora.com>,
        Jonathan Marek <jonathan@marek.ca>,
        Dave Airlie <airlied@redhat.com>,
        linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
        freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20201111083131.39817-1-bernard@vivo.com>
From:   Thomas Zimmermann <tzimmermann@suse.de>
Message-ID: <f704e453-944e-2da8-4f0c-3c9a5c370691@suse.de>
Date:   Wed, 11 Nov 2020 09:51:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201111083131.39817-1-bernard@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi

Am 11.11.20 um 09:31 schrieb Bernard Zhao:
> Hi:
> 
> When call printk, set the KERN_LEVEL is suggested by the community.
> This patch sereies add KERN_* level to printk which do not set
> this level.

I have no say on the msm driver, but IMHO a much better change would be
a conversion to drm_dbg(), drm_err(), etc.

Best regards
Thomas

> 
> Bernard Zhao (5):
>   adreno/a2xx_gpu.c: add KERN_LEVEL to printk
>   adreno/a3xx_gpu.c: add KERN_LEVEL to printk
>   adreno/a4xx_gpu.c: add KERN_LEVEL to printk
>   adreno/a5xx_gpu.c: add KERN_LEVEL to printk
>   adreno/adreno_gpu.c: add KERN_LEVEL to printk
> 
>  drivers/gpu/drm/msm/adreno/a2xx_gpu.c   |  4 ++--
>  drivers/gpu/drm/msm/adreno/a3xx_gpu.c   |  4 ++--
>  drivers/gpu/drm/msm/adreno/a4xx_gpu.c   |  6 +++---
>  drivers/gpu/drm/msm/adreno/a5xx_gpu.c   |  2 +-
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++++++------
>  5 files changed, 14 insertions(+), 14 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer