Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk
 initialization
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Mikko Perttunen <cyndis@kapsi.fi>,
        Viresh Kumar <vireshk@kernel.org>,
        Peter Geis <pgwipeout@gmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20201111011456.7875-1-digetx@gmail.com>
 <20201111011456.7875-11-digetx@gmail.com> <20201111085115.GA4050@kozik-lap>
 <20201111085250.GA11589@kozik-lap>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <0b9fd887-fd57-f948-19b0-d629ed4aa2e7@gmail.com>
Date:   Wed, 11 Nov 2020 12:01:45 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201111085250.GA11589@kozik-lap>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

11.11.2020 11:52, Krzysztof Kozlowski пишет:
>> You added this code in patch #8, so adding-and-removing a piece of code
> Correction: you added this in patch #9.
> 
> Best regards,
> Krzysztof
> 
> 
>> is a nice hint that this patch should be before. Don't add new code
>> which later you simplify. Move all bugfixes and all simplifications to
>> beginning of patchset.
>>
>> That's quite similar case to v6 where you put bugfixes in the middle
>> of patchset.
>>

Indeed, I squashed a similar change in the T124 patch #13, but forgot to
squash it for the T30.