Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp221725pxb; Wed, 11 Nov 2020 01:50:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYHhwC6YCOWs/qYlUV9dbDj8E+pSABsl6FeXMxiHO/syLMlYYd3LVQbSis9GDk0vDw4ycK X-Received: by 2002:a17:906:1902:: with SMTP id a2mr23468165eje.269.1605088227341; Wed, 11 Nov 2020 01:50:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605088227; cv=none; d=google.com; s=arc-20160816; b=rkyYq2vmL7SPCRTgNxsrOAqLHnUMvjLv4xiCfRgVogFlhF1dl7dm16pWjby3EwQ3bs raqNVYOigB+1f+kWQCOl8WMWDJqC033Iri8xC0KLK3w0rMdn73PilthW5t+Nm3ArrABy /hoF5AJfNFIXIJt2bFVlNDJ0Cnflp6RO21tGYHaTKKzI9OeeDsZj14nt+OHi2K/hhSa2 wsUV8t5ZfnlUp3cCkeheUwLUGNQVVW1TIdMdPKhEYVWCv85/HS6Su8YbSORXs44HAAjV MQdekq5jzoNlp17wnKmYbLUal3Ak2MF6Yq6TF6QzaRSao7hjCXjo/FRMfHGPdCZmRZpW 0kqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VEgUVa9qJr6RvT1Q6SEIS3sThGVybgxM2ywhS/TCA+g=; b=gaCILyfBrL3VKR+pV5+IRNSmxO2Yp0i/Lrkw+F90BbjCi5+1b+SE1fnmVmcvMkc5Tl /UztP21S83HWX/+UzhLYCJgbdiujwrakf7mIaKW5NC2boqaxEmTrpVcoNwtC8Cr33tFF U0NAfjYj7TeZAyCgxXx2qAQzdxBnC+pNm4AhUIQjCi/62n5nBoCRzq3ov4VzjJm3ZDup 0KA9LbZoixUnMRO4jp+59HHqE4GAzdm6SkAbesnBGLkew7fkERZCIRD/JwlENMdclJXX o4mn0k3GVZ/LlmQnnWWj4o0iRrIAgsCM2CItb2KpJaRV+gqTXa99fXoBEcMtDpnBSsQr JE2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu5si656216ejb.544.2020.11.11.01.50.02; Wed, 11 Nov 2020 01:50:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbgKKJsA (ORCPT + 99 others); Wed, 11 Nov 2020 04:48:00 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7514 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbgKKJsA (ORCPT ); Wed, 11 Nov 2020 04:48:00 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CWKfF034Rzhjgg; Wed, 11 Nov 2020 17:47:49 +0800 (CST) Received: from huawei.com (10.175.113.25) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Nov 2020 17:47:47 +0800 From: Zheng Zengkai To: , , , CC: , , , , Subject: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe Date: Wed, 11 Nov 2020 17:52:56 +0800 Message-ID: <20201111095256.10477-1-zhengzengkai@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() on one error handling path. This patch fixes that. Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") Reported-by: Hulk Robot Signed-off-by: Zheng Zengkai --- drivers/usb/dwc3/dwc3-meson-g12a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c index 417e05381b5d..bdf1f98dfad8 100644 --- a/drivers/usb/dwc3/dwc3-meson-g12a.c +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c @@ -754,7 +754,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev) ret = priv->drvdata->setup_regmaps(priv, base); if (ret) - return ret; + goto err_disable_clks; if (priv->vbus) { ret = regulator_enable(priv->vbus); -- 2.20.1