Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/2] Add new controls for QP and layer bitrate
To:     Nicolas Dufresne <nicolas@ndufresne.ca>,
        Dikshita Agarwal <dikshita@codeaurora.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Cc:     mchehab@kernel.org, ezequiel@collabora.com,
        stanimir.varbanov@linaro.org, vgarodia@codeaurora.org,
        majja@codeaurora.org
References: <1600693440-3015-1-git-send-email-dikshita@codeaurora.org>
 <871d369fc987ac7cc24bdab9bc9df9fadf939c01.camel@ndufresne.ca>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
Message-ID: <b871bb4d-34ae-6161-5901-8df7fd82c53b@xs4all.nl>
Date:   Wed, 11 Nov 2020 12:47:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <871d369fc987ac7cc24bdab9bc9df9fadf939c01.camel@ndufresne.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 24/09/2020 19:42, Nicolas Dufresne wrote:
> Le lundi 21 septembre 2020 à 18:33 +0530, Dikshita Agarwal a écrit :
>> This series adds frame specific min/max qp controls for hevc and layer
>> wise bitrate control for h264.
> 
> Any chance you could append your driver changes with this set ? I don't
> think new APIs ever make it without a driver using it.

Indeed. I'll mark this as 'Changes Requested' in patchwork: I do need a
version that actually uses these new controls in a driver.

Regards,

	Hans

> 
>>
>> Chnage since v1:
>>  corrected email.
>>
>> Dikshita Agarwal (2):
>>   media: v4l2-ctrl: Add frame-specific min/max qp controls for hevc
>>   media: v4l2-ctrl: Add layer wise bitrate controls for h264
>>
>>  .../userspace-api/media/v4l/ext-ctrls-codec.rst    | 74 +++++++++++++++++++++-
>>  drivers/media/v4l2-core/v4l2-ctrls.c               | 15 +++++
>>  include/uapi/linux/v4l2-controls.h                 | 17 +++++
>>  3 files changed, 104 insertions(+), 2 deletions(-)
>>
>