Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v8 11/26] memory: tegra124-emc: Make driver modular
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Georgi Djakov <georgi.djakov@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Mikko Perttunen <cyndis@kapsi.fi>,
        Viresh Kumar <vireshk@kernel.org>,
        Peter Geis <pgwipeout@gmail.com>,
        Nicolas Chauvet <kwizart@gmail.com>,
        linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20201111011456.7875-1-digetx@gmail.com>
 <20201111011456.7875-12-digetx@gmail.com> <20201111090434.GB4050@kozik-lap>
 <f44b64f5-6b08-5f1e-4f9b-a73a1705d493@gmail.com>
 <20201111092619.GD4050@kozik-lap>
 <a75e72b9-273a-4492-09e6-d02a5ea58482@gmail.com>
Message-ID: <79a2f436-93f6-e461-fb12-6d7c8a8cfac5@gmail.com>
Date:   Wed, 11 Nov 2020 14:53:05 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <a75e72b9-273a-4492-09e6-d02a5ea58482@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

11.11.2020 13:25, Dmitry Osipenko пишет:
> 11.11.2020 12:26, Krzysztof Kozlowski пишет:
>>> 11.11.2020 12:04, Krzysztof Kozlowski пишет:
>>>>> -obj-$(CONFIG_TEGRA124_EMC)		+= clk-tegra124-emc.o
>>>>> +obj-$(CONFIG_ARCH_TEGRA_124_SOC)	+= clk-tegra124-emc.o
>>>>> +obj-$(CONFIG_ARCH_TEGRA_132_SOC)	+= clk-tegra124-emc.o
>>>> How is it related to modularization? It looks like different issue is
>>>> fixed here.
>>> The CONFIG_TEGRA124_EMC now could be 'm', while the clock code must be
>>> built-in. The TEGRA124 EMC driver is used by T124 and T132 SoCs.\
>> Mhmm,  the CONFIG_TEGRA124_EMC depends on ARCH_TEGRA_124_SOC so on the
>> config !ARCH_TEGRA_124_SOC && ARCH_TEGRA_132_SOC this was not
>> selected. Now it will be selected.
>>
> 
> The driver isn't exposed on ARM64 probably because nobody bothered to do
> it so far. But it's not also the memory driver which depends on
> clk-tegra124-emc.o, it's also the main clk/tegra/clk-tegra124.c driver
> itself, which is also used by both T124/132.
> 

Actually, it shouldn't be difficult to keep the old condition for
clk-tegra124-emc.o by slightly improving the Kconfig. I'll do it in the
next revision.