Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp314915pxb; Wed, 11 Nov 2020 04:32:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzUGIKhspxxL+aim91gv35vvee4ck4iP548lffc3PqtpnmiFuXkynB5m4MQSvnJVvAUlCT X-Received: by 2002:a17:906:15cc:: with SMTP id l12mr19731332ejd.363.1605097948939; Wed, 11 Nov 2020 04:32:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605097948; cv=none; d=google.com; s=arc-20160816; b=DDMLYx995bKePM2y/8iJ6UABlVjlhxdo+xsYOZlrn8AR1y1bEtspSUwY9ljrzGRxEq WvJ9+QVBQelDe4e3ZeDtpwdsJkJCCQLMWOK5Q8mz9vq2+KkWkHhMWdgYC4bLWxO1dXpw WDzNtxC0SGGd77/zeDTxmTozkH8FhQeT2G9VaU1mpLfx2+n4Qn5xxuoVIg29231ATq9h QAKig6w2UXBg4xWP7Vemu4irr0JzyGSdAFqi93/nSsHI6bm96HlpebecxXaaRwnM9daD 8G1aMbdFyWfaRMDlCMoIxMpRpRtQBYBggEeDKn1NnhGX2q+c7ZvYC5oJTvr0139+ZcuK T4PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=W5WHawdyiRL/UDPwiBG0yjJUaw2ChXCIaDxzqyGijTM=; b=YoQTpPf01qPtz/3P0BDtLhTkj3S0bqvwDxbDom8BqK573M7y9AUI1z6K5ukI5x1+c0 2hImohgLr2rda4Y5W6YGpyindVMTz5waK3h2pIiWt4b3LSgDLQ3Gy7sBr0WmobHeqAiu OOBdtkHly/iB25SKDKTbBEXM5TaNf4cqMUQ1GT7aAGfgUY8IMcsPggjJ7yqeWC8IJv77 IKRvlL/oNP2JofmxNt6txA9Hq5b6dUO+esDY+Zp4DRDQncboixnnody20wjlKe6r1YmO bCIb5oAH7I0/IOD/xFIZ6x6aZf8Sfpg0WMFZ76YpbGmQY4k5LeBrRLZoVFvOXMsCmC+f EFHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rgp4iBF7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c21si1251371ejr.483.2020.11.11.04.32.03; Wed, 11 Nov 2020 04:32:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rgp4iBF7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726592AbgKKM2A (ORCPT + 99 others); Wed, 11 Nov 2020 07:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgKKM16 (ORCPT ); Wed, 11 Nov 2020 07:27:58 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5394CC0613D1; Wed, 11 Nov 2020 04:27:57 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id q19so1847460ljc.10; Wed, 11 Nov 2020 04:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W5WHawdyiRL/UDPwiBG0yjJUaw2ChXCIaDxzqyGijTM=; b=rgp4iBF7QIwpfxVeWcUQxYv5Jkp6Xu9bjSj0N7rpmVxTxLaHXoguSDfNMidnDczwUM VcKGr0eRkofLJ5ta55sg5miFXEdgXXCR85onduPj33m81gi2Pbk6OaJrFnuUxBn8Vo0+ Ph7+SIiGnaCk0tGPbsl9hQ+pJVG1POv+OJBemTeM0zUrDPvnzXpyXeDOYLvAmClP3DXv Jf6oakkXu8+MAPBp+BZ98KPO8nLq/b9V5dQ+2qguSrPT/NC94DP5PhMYkHzTFOOwiZRh XFEkbxNseJGfqjKeQ7EkgnTrSZybzeRtwtSF2FWQ6R9es6+p/YhENrnK2q28wvg9WY8p Cpsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W5WHawdyiRL/UDPwiBG0yjJUaw2ChXCIaDxzqyGijTM=; b=Z16gYPu7OYx4hIQX1aCDyWC7wRjCRp5W/lXmUJg9vy6LfbsLf1rhtrhWIU+YzHF4+R p0CB8L5LvRWJqfZ153jWeiVetLewjvH1sPsi9RECZR5rE9DjQYHhqZWK2DBKUHbKNhdE 4sFRjQZw7lAXkiR0fgsOukHhqFxfPInduZIYMeA+oypWPb0nsrNPavXp4/FkA1tlpNcy CMSzYhSVimIhR9cozxw++r0iH65GxuC6Oh70wxlX2QWevMgSuSZREFPNkfe2QPKzdnMa m8g/JFPg5CDoiTjaC4lM70Jj3sshf9UFzrVC6Z9Exw1LAM9t1JMa62g1MD0ATo+/Xad8 wmpQ== X-Gm-Message-State: AOAM530uRXOqFqQ8LodPuEAWSZXXkQtBHcG1KldUy58vOCd15wqh/wcn /sftaeK2d/HtqxdH0eGPYQE= X-Received: by 2002:a2e:9a43:: with SMTP id k3mr10978389ljj.69.1605097675775; Wed, 11 Nov 2020 04:27:55 -0800 (PST) Received: from elitebook.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id x6sm206676lfn.185.2020.11.11.04.27.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 04:27:54 -0800 (PST) Subject: Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node To: Florian Fainelli , Vladimir Oltean Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , Jakub Kicinski , Rob Herring , Ray Jui , Scott Branden , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" , Hauke Mehrtens , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , Kurt Kanzenbach References: <20201110033113.31090-1-f.fainelli@gmail.com> <20201110033113.31090-6-f.fainelli@gmail.com> <20201110221221.4sxx5h3346no7y3y@skbuf> <3e87038f-9e2e-676c-a000-0e6c0e8b6ae4@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: <581c3e62-9d2e-f684-b035-46aeb7a52816@gmail.com> Date: Wed, 11 Nov 2020 13:27:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.11.2020 02:48, Florian Fainelli wrote: > On 11/10/2020 2:13 PM, Florian Fainelli wrote: >> On 11/10/20 2:12 PM, Vladimir Oltean wrote: >>> On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: >>>> Provide an empty 'ports' container node with the correct #address-cells >>>> and #size-cells properties. This silences the following warning: >>>> >>>> arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: >>>> ethernet-switch@18007000: 'oneOf' conditional failed, one must be fixed: >>>> 'ports' is a required property >>>> 'ethernet-ports' is a required property >>>> From schema: >>>> Documentation/devicetree/bindings/net/dsa/b53.yaml >>>> >>>> Signed-off-by: Florian Fainelli >>>> --- >>>> arch/arm/boot/dts/bcm5301x.dtsi | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi >>>> index 807580dd89f5..89993a8a6765 100644 >>>> --- a/arch/arm/boot/dts/bcm5301x.dtsi >>>> +++ b/arch/arm/boot/dts/bcm5301x.dtsi >>>> @@ -489,6 +489,10 @@ srab: ethernet-switch@18007000 { >>>> status = "disabled"; >>>> >>>> /* ports are defined in board DTS */ >>>> + ports { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + }; >>> >>> This look a bit 'lone wolf' here. Not sure how much time you intend to >>> spend on this, but FWIW, others prefer to declare all ports in the SoC >>> DTSI with status = "disabled", and just enable the ones used per-board, >>> and add labels and PHY handles also per-board. Example: fsl-ls1028a.dtsi >>> and fsl-ls1028a-rdb.dts. >> >> That's a good suggestion, I could do that. > > There is quite a bit of variation between designs and how the ports are > assigned and it would end up being quite verbose, so I will punt that > for now. I agree with Florian, boards (vendors) use ports really randomly so pretty much every device needs that defined from the scratch.