Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR
To:     Richard Cochran <richardcochran@gmail.com>,
        Wang Qing <wangqing@vivo.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Samuel Zou <zou_wei@huawei.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1604649411-24886-1-git-send-email-wangqing@vivo.com>
 <20201107150803.GD9653@hoboy.vegasvil.org>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <fbe087bc-5453-00cc-65d4-8c660e6587ed@ti.com>
Date:   Wed, 11 Nov 2020 15:03:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201107150803.GD9653@hoboy.vegasvil.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/11/2020 17:08, Richard Cochran wrote:
> On Fri, Nov 06, 2020 at 03:56:45PM +0800, Wang Qing wrote:
>> We always have to update the value of ret, otherwise the
>>   error value may be the previous one.
>>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
> 
> Acked-by: Richard Cochran <richardcochran@gmail.com>
> 

Following Richard's comments:

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

> 
>> ---
>>   drivers/net/ethernet/ti/am65-cpts.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/ti/am65-cpts.c b/drivers/net/ethernet/ti/am65-cpts.c
>> index 75056c1..b77ff61
>> --- a/drivers/net/ethernet/ti/am65-cpts.c
>> +++ b/drivers/net/ethernet/ti/am65-cpts.c
>> @@ -1001,8 +1001,7 @@ struct am65_cpts *am65_cpts_create(struct device *dev, void __iomem *regs,
>>   	if (IS_ERR_OR_NULL(cpts->ptp_clock)) {
>>   		dev_err(dev, "Failed to register ptp clk %ld\n",
>>   			PTR_ERR(cpts->ptp_clock));
>> -		if (!cpts->ptp_clock)
>> -			ret = -ENODEV;
>> +		ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV);
>>   		goto refclk_disable;
>>   	}
>>   	cpts->phc_index = ptp_clock_index(cpts->ptp_clock);
>> -- 
>> 2.7.4
>>

-- 
Best regards,
grygorii