Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is
 ERROR
To:     Richard Cochran <richardcochran@gmail.com>,
        Wang Qing <wangqing@vivo.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Samuel Zou <zou_wei@huawei.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1605086686-5140-1-git-send-email-wangqing@vivo.com>
 <20201111123224.GB29159@hoboy.vegasvil.org>
Message-ID: <cd2aa8a1-183c-fb15-0a74-07852afb0cb8@ti.com>
Date:   Wed, 11 Nov 2020 15:24:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201111123224.GB29159@hoboy.vegasvil.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

hi Jakub,

On 11/11/2020 14:32, Richard Cochran wrote:
> On Wed, Nov 11, 2020 at 05:24:41PM +0800, Wang Qing wrote:
>> We always have to update the value of ret, otherwise the error value
>>   may be the previous one. And ptp_clock_register() never return NULL
>>   when PTP_1588_CLOCK enable.
> 
> NAK.
> 
> Your code must handle the possibility that ptp_clock_register() can
> return NULL.  Why?
> 
> 1. Because that follows the documented API.
> 
> 2. Because people will copy/paste this driver.
> 
> 3. Because the Kconfig for your driver can change without warning.

Following Richard's comments v1 of the patch has to be applied [1].
I've also added my Reviewed-by there.

[1] https://lore.kernel.org/patchwork/patch/1334067/
-- 
Best regards,
grygorii