Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201111141529.98147-1-alexandru.ardelean@analog.com> <CAHp75VcKmiBM1WQTtmJ7L3kpB1xdXX=xOtM2zCAtaszXBcHokg@mail.gmail.com>
In-Reply-To: <CAHp75VcKmiBM1WQTtmJ7L3kpB1xdXX=xOtM2zCAtaszXBcHokg@mail.gmail.com>
From:   Alexandru Ardelean <ardeleanalex@gmail.com>
Date:   Wed, 11 Nov 2020 16:54:08 +0200
Message-ID: <CA+U=DsrNLR=5LyoCjdtyD9Y=KddZVyE8c+cLr2Xzef68iyeSyA@mail.gmail.com>
Subject: Re: [PATCH] spi: Add SPI_NO_TX/RX support
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Alexandru Ardelean <alexandru.ardelean@analog.com>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        "Bogdan, Dragos" <dragos.bogdan@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 11, 2020 at 4:45 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Nov 11, 2020 at 4:13 PM Alexandru Ardelean
> <alexandru.ardelean@analog.com> wrote:
> >
> > From: Dragos Bogdan <dragos.bogdan@analog.com>
> >
> > Transmit/receive only is a valid SPI mode. For example, the MOSI/TX lin=
e
> > might be missing from an ADC while for a DAC the MISO/RX line may be
> > optional. This patch adds these two new modes: SPI_NO_TX and
> > SPI_NO_RX. This way, the drivers will be able to identify if any of
> > these two lines is missing and to adjust the transfers accordingly.
>
> Shouldn't this update a binding documentation?

oh,
good catch

>
> ...
>
> > -       /* check mode to prevent that DUAL and QUAD set at the same tim=
e
> > +       /* check mode to prevent that any two of DUAL, QUAD and NO_MOSI=
/MISO
> > +        * are set at the same time
> >          */
>
> /*
>  * Perhaps switch to proper multi-line comment style
>  * at the same time?
>  */

=C2=AF\_(=E3=83=84)_/=C2=AF

Not sure what SPI prefers as multi-line comment style,
But ok.

>
> ...
>
> >  #define        SPI_TX_OCTAL    0x2000                  /* transmit wit=
h 8 wires */
> >  #define        SPI_RX_OCTAL    0x4000                  /* receive with=
 8 wires */
> >  #define        SPI_3WIRE_HIZ   0x8000                  /* high impedan=
ce turnaround */
> > +#define        SPI_NO_TX       0x10000                 /* no transmit =
wire */
> > +#define        SPI_NO_RX       0x20000                 /* no receive w=
ire */
>
> Perhaps switch to use BIT() instead at some point (as a prerequisite
> patch, for example)

I'll leave this up to the maintainer preference.
Maybe I'll do it as a second patch here, so that I can be dropped.

>
> --
> With Best Regards,
> Andy Shevchenko