Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp415709pxb; Wed, 11 Nov 2020 06:57:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJxMpUDLVbb5CL3pXDjx+N24Vooq/JG7jttuuSz+eNCX3sMT+ckHh+gMLuyjUxqKI/Zmz4i4 X-Received: by 2002:a17:906:8144:: with SMTP id z4mr25028954ejw.251.1605106642194; Wed, 11 Nov 2020 06:57:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605106642; cv=none; d=google.com; s=arc-20160816; b=wzItg0rYNnuxFw5KKWMm64eVQfF5mf6Hv3pAjhwQZLZMUdbuvqzM40i3aLYDMSWGlO /rSavo5zk7e+SNzsX79NiwOsOQtEYIR22bp0drKr5j+KYrtTL0DuHGduuS2zSTWKbKyK 299RHoUi3Bhh1lU+JbSKiA2PpaTqmG3EU20X0yBmOff0JiwmoUx0TDr6AaziGNM7lHms xjyXcxI/fKHyMmAiF/Pv6t6RX2+B/sAD6TZL/tfklLg/db9vyEa3n2HKZJ2GvLF7IDVT v0ys0thSbkT1y5T6jyTd5Re0Igz0GtHRLQMYAJTGHfiO/kVUzoTk6/9d6/VNMAI0if52 dfJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HjIV86G4+zXJRkvdg3A94EY+lDllWpujuARJLy+GgHg=; b=Y+FiTn1Ce7wiInZWk7L3E2DVlVC2UGykvXi25b64P7dMAgVgqSsNDNhLELJOA/stTN xGoV1BR3ZxUf1K/Ujd/wxCrOD4NpG5oOlSraP/FhNtVO8LEUD60vV9qh+CTuijgD0oE3 j4l/2DkYZg2byAWSLZp/lzA5wtDxV3tNClLXZ+vDBqP6uxyyU5S2XRRlWGcHgw3XU+IK AtVqqMmV7rnprfrIK9CwE6spM9c41Zmi4kLx5/vP2w+X07GT9q2tLuea4hsqx+f+QsF9 v+g9AGiwMqSIx5Q1WTX+4iM5V1xX461uXr4+NW0cRFT8MeKSxwdN/9tC0w6P2yfDRybX wLrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="e/ZEKaNy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si1652024ede.493.2020.11.11.06.56.58; Wed, 11 Nov 2020 06:57:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="e/ZEKaNy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726849AbgKKOy3 (ORCPT + 99 others); Wed, 11 Nov 2020 09:54:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59314 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727246AbgKKOxu (ORCPT ); Wed, 11 Nov 2020 09:53:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605106429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HjIV86G4+zXJRkvdg3A94EY+lDllWpujuARJLy+GgHg=; b=e/ZEKaNyO7NBJ8K+8/2wWRmhjui8//LCuA9sZgFhK/X4R5vNsZx3SE6MYA/nfRy4c+cEJE kwUltwisr/shEmr7qVzzd1YWUkjc6zqzphcRHb2fVPUwnbx9KshCoFNOrT3NV32/nheSl3 luZt8c5RyxWf/dx9Yemk+krP0kStQN0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-hceWkfh2NFaINwskg_F-hQ-1; Wed, 11 Nov 2020 09:53:46 -0500 X-MC-Unique: hceWkfh2NFaINwskg_F-hQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5E7E1099F63; Wed, 11 Nov 2020 14:53:44 +0000 (UTC) Received: from t480s.redhat.com (ovpn-114-151.ams2.redhat.com [10.36.114.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F3A2380; Wed, 11 Nov 2020 14:53:42 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Oscar Salvador , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rashmica Gupta , Andrew Morton , Mike Rapoport , Michal Hocko , Wei Yang Subject: [PATCH v2 5/8] powerpc/mm: print warning in arch_remove_linear_mapping() Date: Wed, 11 Nov 2020 15:53:19 +0100 Message-Id: <20201111145322.15793-6-david@redhat.com> In-Reply-To: <20201111145322.15793-1-david@redhat.com> References: <20201111145322.15793-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let's print a warning similar to in arch_add_linear_mapping() instead of WARN_ON_ONCE() and eventually crashing the kernel. Reviewed-by: Oscar Salvador Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Rashmica Gupta Cc: Andrew Morton Cc: Mike Rapoport Cc: Michal Hocko Cc: Oscar Salvador Cc: Wei Yang Signed-off-by: David Hildenbrand --- arch/powerpc/mm/mem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c index ca5c4b54c366..c5755b9efb64 100644 --- a/arch/powerpc/mm/mem.c +++ b/arch/powerpc/mm/mem.c @@ -150,7 +150,9 @@ void __ref arch_remove_linear_mapping(u64 start, u64 size) mutex_lock(&linear_mapping_mutex); ret = remove_section_mapping(start, start + size); mutex_unlock(&linear_mapping_mutex); - WARN_ON_ONCE(ret); + if (ret) + pr_warn("Unable to remove linear mapping for 0x%llx..0x%llx: %d\n", + start, start + size, ret); /* Ensure all vmalloc mappings are flushed in case they also * hit that section of memory -- 2.26.2