Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp540874pxb; Wed, 11 Nov 2020 09:48:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAPWSaiqW8IeIQpode6ZO+SOQHEVXM8YHtgZznu2WtyXmUqhrawGbENr+avSoGvcHx1xNE X-Received: by 2002:aa7:d8c4:: with SMTP id k4mr667383eds.248.1605116928338; Wed, 11 Nov 2020 09:48:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605116928; cv=none; d=google.com; s=arc-20160816; b=EE96KM8axUM7jz5omDjFIatfqyfb8KNQsC6CVp1lyNvViv3jhd4BKO5sJJRo05REsI mbxA4OQhXfPHaC9qWNDRXy1woIAlxvRvkWFC0xIJ/Py/+KMPMs5C4MDOWKN1hUjByegb WTCf2VpwuIkdZWD78o6ndermtdi3Np4nxs8NaeHwDiIDfQg41Suwii3KzVrC8ygWorpc qyUtNuW7x7xytPnwctTqMxSPtKfgOdRXle5JIjiDZp4zUaQhGUlK3b5xtItfdNU9mrWx XIU1OAcPVY06BiOd1sh+SPp+DcMzM135ScoIyU3UUJyeFRYJhM4+REZO3ej8j6G1v0UB kCeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=rqYs3xjRyWzic8meSeTOwvht9StvnHkulHZorvGXVBc=; b=xdz8sylTBY4aUf7HFA6EImXW4vlkjvjZeJ/+WKNFzyE851+6pjw3N9MaRhAOzjRqxS MEDfs5VONVGyf2RhIuDj2sTfx0BrC8JyLW0LLv4Pl9o75NguBblWwQjgZM5fwuAhmFqU +TB3m8DWW5k3C79+BMnVgsZmHEmlEY1H0h6dnXpeDLhNSTCPPcDGxz1egDqBfjwtJip2 93GhO6OJHDkSCJ5nd+7KqmQlp4OAYmWw/523SFGAMyjjZVNQ3JFtqcPlGHmosbo9v5Ub mnwg8qO7sikh+hSpjFnfoZqH5FNg2ulcNsIzBut73EjV2uxT1I6VeaUnUVNGrMlt8z2B jYFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si1769050ejs.498.2020.11.11.09.48.24; Wed, 11 Nov 2020 09:48:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgKKRqg (ORCPT + 99 others); Wed, 11 Nov 2020 12:46:36 -0500 Received: from mx2.suse.de ([195.135.220.15]:58660 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgKKRqf (ORCPT ); Wed, 11 Nov 2020 12:46:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9A8E8AB95; Wed, 11 Nov 2020 17:46:33 +0000 (UTC) Subject: Re: [PATCH v21 17/19] mm/lru: replace pgdat lru_lock with lruvec lock To: Alex Shi , akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Cc: Michal Hocko , Yang Shi References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <1604566549-62481-18-git-send-email-alex.shi@linux.alibaba.com> From: Vlastimil Babka Message-ID: <337c6223-a469-123e-7f53-963b0a1cc164@suse.cz> Date: Wed, 11 Nov 2020 18:46:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1604566549-62481-18-git-send-email-alex.shi@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/20 9:55 AM, Alex Shi wrote: > This patch moves per node lru_lock into lruvec, thus bring a lru_lock for > each of memcg per node. So on a large machine, each of memcg don't > have to suffer from per node pgdat->lru_lock competition. They could go > fast with their self lru_lock. > > After move memcg charge before lru inserting, page isolation could > serialize page's memcg, then per memcg lruvec lock is stable and could > replace per node lru lock. > > In func isolate_migratepages_block, compact_unlock_should_abort and > lock_page_lruvec_irqsave are open coded to work with compact_control. > Also add a debug func in locking which may give some clues if there are > sth out of hands. > > Daniel Jordan's testing show 62% improvement on modified readtwice case > on his 2P * 10 core * 2 HT broadwell box. > https://lore.kernel.org/lkml/20200915165807.kpp7uhiw7l3loofu@ca-dmjordan1.us.oracle.com/ > > On a large machine with memcg enabled but not used, the page's lruvec > seeking pass a few pointers, that may lead to lru_lock holding time > increase and a bit regression. > > Hugh Dickins helped on the patch polish, thanks! > > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Rong Chen > Cc: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Yang Shi > Cc: Matthew Wilcox > Cc: Konstantin Khlebnikov > Cc: Tejun Heo > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: cgroups@vger.kernel.org Acked-by: Vlastimil Babka