Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp617641pxb; Wed, 11 Nov 2020 11:46:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJywIgW3ISy7HqBQM3NbQRMMzijNoqI/ddBJozfQF2fUXb0puiIHkIY/APQF5YITYGYncWB2 X-Received: by 2002:a50:8064:: with SMTP id 91mr1310739eda.172.1605124011798; Wed, 11 Nov 2020 11:46:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605124011; cv=none; d=google.com; s=arc-20160816; b=YdowCRFfiDfZGdp40Ubg5XAFP2ySDfQpRF4x4pBoszI0PQjaWfXs5YeHAT5f0PiT9u gjsc0kdiFdv+3o5AaP4NukwMd0sRgqXIcTUwiX/E57aEjSZPhgCPeremv5P/wbPMam/e NNT2vW1AE0thRPSbT3z7VlXYKIGYO8i0u+JstRud/rc/Y5RIUCvR3N7mK9ZA6ATwQoY9 RNRYCmI8sqX5UZi2ouMsPqrVt8/Ckyaf2+aCbJrLWAXEB5IDSmxo2WVtcVCBHXvFZBVy UdCCWppncMYlAnXxslg5PW2xa/0TI1to7TOw2BcBIUCKXEi/aLS3J9GBCZN1NPyBSsSH VFrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=kcqgsA1C03N+sBAIpewIwQ5iiWf5Tl1aifp7Xa5kwsU=; b=x3+J2YZaqncb3PfaKto2760yHSteTh6docno6w9lN57BTaPqXxM5J70uGs0q1zR7Rc +SAgFIk1fcME0b1Hdn+qCqs6Zg0s9+d5njiX7qpTedIzVOjtrIC84FZyHML3vqPbCnyr OgmIKiHfZRPDegjMFGE1VwA6x+52SyaENZasvE2uplvZyWRJOuL0P210V1RCz83mkiTr L9eNridHbIDf+LkDr2eL7R5B+Y77S8ooeeFG/x4/VkWyFzy9n6eDDCN7il+FnIKYK/V1 gUYf56cAddhPXaqP4o7/EOI+quobhJUj6EyelDjB9hXEMNRg5Aa41YhGkHeDwWDzom9c 75ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=hxxN1bsV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si2614015edw.241.2020.11.11.11.46.28; Wed, 11 Nov 2020 11:46:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=hxxN1bsV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbgKKTmW (ORCPT + 99 others); Wed, 11 Nov 2020 14:42:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727629AbgKKTmP (ORCPT ); Wed, 11 Nov 2020 14:42:15 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 124CBC0613D4; Wed, 11 Nov 2020 11:42:15 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id ay21so3591415edb.2; Wed, 11 Nov 2020 11:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kcqgsA1C03N+sBAIpewIwQ5iiWf5Tl1aifp7Xa5kwsU=; b=hxxN1bsVIxKHJ2u+OGXh4vbrnNxJtt03MwyFm3BYAAY+F8QzijYemQF0oYHQjHHp57 l7OyLE/flv2yXl8Q+5Nxs63NVYrl+pfl/o/J7qP8/ChFENuCl79FnQe6EL8rBb7TgAvC YhYGzxeZsqT4vTASOaiX7Jk+C6jKE0rs731aj41UbiXSUYsitZiPWR3V79ddeMlupYVD C+jONWN/Y+OLtKwwKUq9bwhLr4oqQducG6fdodCglTQAEW8rEhwDgnzxP+nIGVRER5dE c87D1e3UbG/7ZwVeH0irqZvbi8i5Ug1enHf6zE1J05nvfuFzgXVp/Q1vYPPqBrf9HKKy AF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kcqgsA1C03N+sBAIpewIwQ5iiWf5Tl1aifp7Xa5kwsU=; b=hwXlNbhrvn3NE164Pqx2eaMhYDPCCMent7qEqutP94yP/tR6hQoTu8PhqVAyogz4tf 13Qyhp0BPmP2k/quYKJvR5EV9N0btDFBsDCIg0JG809LtRhbB8FdJOnauSoRQdfPoblH Qz5C0soT4L/8EuDccnOSAT+1Z1HPkW3LdeLz+U/fWBCYzWav/iDkvP5lq5novVzv3HEA /CNpDVgtbhkmKOwX9L7EyCur4lK/bMkyHeRJagGm9g+/OWt/kNaY3mAZZwYQAWhgrnTV OSGd34+0zHDwVHEPhujhKH94PYZJ3Vpn457nziyItCOTHzEWwWGxabDZ3Cm8qyNzPZR2 2URA== X-Gm-Message-State: AOAM533YGg5zPf+WROgR/IkXcAtzcZYnXeaO3Gy445o5TC03qRuEzSK/ 3p5EaS6yKBZHDNWwVPmc4Pw+QawPGR3YrTwHUQQ= X-Received: by 2002:a05:6402:2059:: with SMTP id bc25mr1241699edb.13.1605123733810; Wed, 11 Nov 2020 11:42:13 -0800 (PST) MIME-Version: 1.0 References: <20201111095256.10477-1-zhengzengkai@huawei.com> In-Reply-To: <20201111095256.10477-1-zhengzengkai@huawei.com> From: Martin Blumenstingl Date: Wed, 11 Nov 2020 20:42:02 +0100 Message-ID: Subject: Re: [PATCH] usb: dwc3: meson-g12a: disable clk on error handling path in probe To: Zheng Zengkai Cc: balbi@kernel.org, gregkh@linuxfoundation.org, khilman@baylibre.com, Neil Armstrong , linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 10:48 AM Zheng Zengkai wrote: > > dwc3_meson_g12a_probe() does not invoke clk_bulk_disable_unprepare() > on one error handling path. This patch fixes that. > > Fixes: 347052e3bf1b ("usb: dwc3: meson-g12a: fix USB2 PHY initialization on G12A and A1 SoCs") > Reported-by: Hulk Robot > Signed-off-by: Zheng Zengkai Reviewed-by: Martin Blumenstingl many thanks for this fix! Best regards Martin